1385932 - Re-enable browser_urlbar_search_reflows.js for Linux builds

Status: RESOLVED FIXED

(Firefox :: Search, defect, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

browser_urlbar_search_reflows.js was added in bug 1356271, but disabled for Linux due to frequent failures. Here's a log snippet:

[task 2017-07-29T17:12:24.834315Z] 17:12:24     INFO - TEST-PASS | browser/base/content/test/performance/browser_urlbar_search_reflows.js | expected uninterruptible reflow: '[
[task 2017-07-29T17:12:24.839062Z] 17:12:24     INFO - 	"adjustHeight@chrome://global/content/bindings/autocomplete.xml:1289:31",
[task 2017-07-29T17:12:24.839962Z] 17:12:24     INFO - 	"_invalidate/this._adjustHeightTimeout<@chrome://global/content/bindings/autocomplete.xml:1186:58",
[task 2017-07-29T17:12:24.840787Z] 17:12:24     INFO - 	"setTimeout handler*_invalidate@chrome://global/content/bindings/autocomplete.xml:1186:41",
[task 2017-07-29T17:12:24.841546Z] 17:12:24     INFO - 	"invalidate@chrome://global/content/bindings/autocomplete.xml:1164:11",
[task 2017-07-29T17:12:24.842392Z] 17:12:24     INFO - 	"testFn/popup.invalidate@chrome://mochitests/content/browser/browser/base/content/test/performance/browser_urlbar_search_reflows.js:252:7",
[task 2017-07-29T17:12:24.843234Z] 17:12:24     INFO - 	"testFn/popup.invalidate@chrome://mochitests/content/browser/browser/base/content/test/performance/browser_urlbar_search_reflows.js:252:7",
[task 2017-07-29T17:12:24.844061Z] 17:12:24     INFO - 	"notifyResults@jar:file:///home/worker/workspace/build/application/firefox/omni.ja!/components/UnifiedComplete.js:2214:5",
[task 2017-07-29T17:12:24.844881Z] 17:12:24     INFO - 	"finishSearch@jar:file:///home/worker/workspace/build/application/firefox/omni.ja!/components/UnifiedComplete.js:2387:5",
[task 2017-07-29T17:12:24.845691Z] 17:12:24     INFO - 	"startSearch/<@jar:file:///home/worker/workspace/build/application/firefox/omni.ja!/components/UnifiedComplete.js:2344:33",
[task 2017-07-29T17:12:24.846552Z] 17:12:24     INFO - 	"promise callback*startSearch@jar:file:///home/worker/workspace/build/application/firefox/omni.ja!/components/UnifiedComplete.js:2337:5",
[task 2017-07-29T17:12:24.847998Z] 17:12:24     INFO - 	"promiseAutocompleteResultPopup@chrome://mochitests/content/browser/browser/base/content/test/performance/browser_urlbar_search_reflows.js:183:3",
[task 2017-07-29T17:12:24.851942Z] 17:12:24     INFO - 	"async*testFn@chrome://mochitests/content/browser/browser/base/content/test/performance/browser_urlbar_search_reflows.js:260:11",
[task 2017-07-29T17:12:24.855192Z] 17:12:24     INFO - 	"async*withReflowObserver@chrome://mochitests/content/browser/browser/base/content/test/performance/head.js:128:11",
[task 2017-07-29T17:12:24.856248Z] 17:12:24     INFO - 	"async*@chrome://mochitests/content/browser/browser/base/content/test/performance/browser_urlbar_search_reflows.js:265:9",
[task 2017-07-29T17:12:24.857319Z] 17:12:24     INFO - 	"Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:798:21",
[task 2017-07-29T17:12:24.858313Z] 17:12:24     INFO - 	"TaskImpl_run@resource://gre/modules/Task.jsm:331:42",
[task 2017-07-29T17:12:24.859391Z] 17:12:24     INFO - 	"promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:408:7",
[task 2017-07-29T17:12:24.860412Z] 17:12:24     INFO - 	"TaskImpl_run@resource://gre/modules/Task.jsm:339:15",
[task 2017-07-29T17:12:24.861368Z] 17:12:24     INFO - 	"TaskImpl@resource://gre/modules/Task.jsm:280:3",
[task 2017-07-29T17:12:24.862348Z] 17:12:24     INFO - 	"asyncFunction@resource://gre/modules/Task.jsm:252:14",
[task 2017-07-29T17:12:24.863297Z] 17:12:24     INFO - 	"Task_spawn@resource://gre/modules/Task.jsm:166:12",
[task 2017-07-29T17:12:24.867312Z] 17:12:24     INFO - 	"Tester_execTest@chrome://mochikit/content/browser-test.js:789:9",
[task 2017-07-29T17:12:24.868188Z] 17:12:24     INFO - 	"Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:689:7",
[task 2017-07-29T17:12:24.869026Z] 17:12:24     INFO - 	"SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59",
[task 2017-07-29T17:12:24.869686Z] 17:12:24     INFO - 	""
[task 2017-07-29T17:12:24.870357Z] 17:12:24     INFO - ]' - true == true - 
[task 2017-07-29T17:12:24.871183Z] 17:12:24     INFO - Buffered messages logged at 17:05:46
[task 2017-07-29T17:12:24.872079Z] 17:12:24     INFO - Longer timeout required, waiting longer...  Remaining timeouts: 2
[task 2017-07-29T17:12:24.873730Z] 17:12:24     INFO - Buffered messages finished
[task 2017-07-29T17:12:24.874702Z] 17:12:24    ERROR - TEST-UNEXPECTED-TIMEOUT | browser/base/content/test/performance/browser_urlbar_search_reflows.js | application timed out after 330 seconds with no output
[task 2017-07-29T17:12:24.878156Z] 17:12:24    ERROR - Force-terminating active process(es).
[task 2017-07-29T17:12:24.879181Z] 17:12:24     INFO - Determining child pids from psutil
[task 2017-07-29T17:12:24.880113Z] 17:12:24     INFO - Found child pids: [1358, 1400, 1415, 1468]
[task 2017-07-29T17:12:24.881143Z] 17:12:24     INFO - Killing process: 1358
[task 2017-07-29T17:12:24.885604Z] 17:12:24     INFO - TEST-INFO | started process screentopng
[task 2017-07-29T17:12:24.886424Z] 17:12:24     INFO - TEST-INFO | screentopng: exit 0
[task 2017-07-29T17:12:24.887241Z] 17:12:24     INFO - Killing process: 1400
[task 2017-07-29T17:12:24.888164Z] 17:12:24     INFO - Not taking screenshot here: see the one that was previously logged
[task 2017-07-29T17:12:24.892267Z] 17:12:24     INFO - Killing process: 1415
[task 2017-07-29T17:12:24.893327Z] 17:12:24     INFO - Not taking screenshot here: see the one that was previously logged
[task 2017-07-29T17:12:24.894137Z] 17:12:24     INFO - Killing process: 1468
[task 2017-07-29T17:12:24.894959Z] 17:12:24     INFO - Not taking screenshot here: see the one that was previously logged
[task 2017-07-29T17:12:38.257663Z] 17:12:38  WARNING - failed to kill pid 1400 after 30s
[task 2017-07-29T17:12:38.260297Z] 17:12:38  WARNING - failed to kill pid 1358 after 30s
[task 2017-07-29T17:12:38.260651Z] 17:12:38  WARNING - failed to kill pid 1415 after 30s
[task 2017-07-29T17:12:38.263159Z] 17:12:38  WARNING - failed to kill pid 1468 after 30s
[task 2017-07-29T17:12:38.266239Z] 17:12:38     INFO - Killing process: 1311
[task 2017-07-29T17:12:38.268331Z] 17:12:38     INFO - Not taking screenshot here: see the one that was previously logged
[task 2017-07-29T17:12:39.013926Z] 17:12:39     INFO - TEST-INFO | Main app process: exit 6
[task 2017-07-29T17:12:39.015979Z] 17:12:39    ERROR - TEST-UNEXPECTED-FAIL | ShutdownLeaks | process() called before end of test suite
[task 2017-07-29T17:12:39.016245Z] 17:12:39     INFO - Buffered messages finished
[task 2017-07-29T17:12:39.023794Z] 17:12:39    ERROR - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_urlbar_search_reflows.js | application terminated with exit code 6

Not sure what's timing out here, but we should figure it out.

Comment 1

[Dale Harvey (:daleharvey)]

Will take a look at this too

Comment 2

[Dale Harvey (:daleharvey)]

Gave this like 20 runs, also looks fixed - https://treeherder.mozilla.org/#/jobs?repo=try&revision=8130ff071d5af6f4eb9ffb7cb5f40add148c6a7d

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: Bug 1385932 - Reenable browser_urlbar_search_reflows.js on Linux.

Review commit: https://reviewboard.mozilla.org/r/198046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/198046/

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8926796 [details]
Bug 1385932 - Reenable browser_urlbar_search_reflows.js on Linux.

https://reviewboard.mozilla.org/r/198046/#review203364

\o/ Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d253ab30bac2
Reenable browser_urlbar_search_reflows.js on Linux. r=mconley

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d253ab30bac2