1385957 - [traceback] KeyError: 'json_dump' in OSInfoRule

Status: RESOLVED FIXED

(Socorro :: Processor, task)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

From: https://sentry.prod.mozaws.net/operations/socorro-prod/issues/606815/

"""
KeyError: 'json_dump'
  File "socorro/lib/transform_rules.py", line 148, in action
    return self._action(*args, **kwargs)
  File "socorro/processor/general_transform_rules.py", line 56, in _action
    system_info = processed_crash.json_dump.get('system_info')
"""

That's in OSInfoRule. I fixed this issue in CPUInfoRule already.

This bug covers fixing OSInfoRule json_dump usage.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 3873

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/9926fe7efce03a4a7f11c91a692ed6f62f31dd4c
fixes bug 1385957 - fix to safely get json_dump (#3873)

* fixes bug 1385957 - fix to safely get json_dump

* Fix goof where it defaulted to None which is equally bad

* Fix broken test

The test expected _action() to throw an exception and return False, but it
doesn't do that anymore. This fixes that aspect of the test.