Closed Bug 1386020 Opened 2 years ago Closed 2 years ago

Use wr::IdNamespace instead of raw uint32_t for namespace in C++ code

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: kats, Assigned: kats)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

The WR rust code has a IdNamespace type that is used in more places now (as of a recent WR update). However on the C++ side we're still using raw uint32_t in a bunch of places. We should upgrade that to a wr::IdNamespace to be more strongly typed.
Comment on attachment 8892163 [details]
Bug 1386020 - Use wr::IdNamespace instead of uint32_t for the WR namespace.

https://reviewboard.mozilla.org/r/163134/#review168538
Attachment #8892163 - Flags: review?(sotaro.ikeda.g) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/310c1b6a7127
Use wr::IdNamespace instead of uint32_t for the WR namespace. r=sotaro
https://hg.mozilla.org/mozilla-central/rev/310c1b6a7127
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.