1386073 - Queue OMTP Captures and replay them after we've captured everything

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Mason Chang [Inactive] [:mchang]]

Attachment: Queue up OMTP paints

To support async capture and replay, we can queue up captures on the Paint Thread with their respective states. Then replay them in one go on the Paint Thread. We need this because we can draw to multiple draw targets with a rotated buffer while painting a client painted layer.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: Queue up OMTP paints

Comment 2

[Mason Chang [Inactive] [:mchang]]

Attachment: Don't set RotatedBuffer's returned DrawTarget transform

This way we don't set the transform when we BorrowDrawTarget from a ContentClient. Then we send the captured contents off to the paint thread to paint. We can iterate through the DTs + paint them at the same time.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8892227 [details] [diff] [review]
Queue up OMTP paints

Review of attachment 8892227 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/PaintThread.cpp
@@ +135,5 @@
> +
> +    // Textureclient forces a flush once we "end paint", so
> +    // users of this texture expect all the drawing to be complete.
> +    // Force a flush now.
> +    // TODO: This might be a performance bottleneck because

Large flushes may be contributing to the device reset problems, so we may want to end up having a preference for "flush per draw target" vs. "flush after everything".

Comment 4

[Mason Chang [Inactive] [:mchang]]

Try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=c63b74739c34edd1b5be2798b2d3c79dc6681172&selectedJob=120202819

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db753f92f801
Don't set RotatedBuffer's returned DrawTarget transform with omtp. r=dvander

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/db753f92f801