1386108 - Update Computed stylesheet to use more specific selectors

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

In Bug 1242201, we will be adding the markup.css stylesheet to inspector.xhtml. We have some selector conflicts between the markup and computed view. This is to make the selectors in computed.css more specific.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d259fac59edb6a54862fd78dc5cba0e97642bdc

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1386108 - Update Computed stylesheet to use more specific selectors.

Review commit: https://reviewboard.mozilla.org/r/163426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163426/

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8892456 [details]
Bug 1386108 - Update Computed stylesheet to use more specific selectors.

https://reviewboard.mozilla.org/r/163426/#review168854

I would have preferred to stick with computedview rather than computed as the prefix. Looks good otherwise.
I can't see the try results at the moment (looks like treeherder has some difficulties?) so R+ with a green try.

::: devtools/client/inspector/inspector.xhtml:122
(Diff revision 1)
>  
>        <div id="sidebar-panel-computedview" class="devtools-monospace theme-sidebar inspector-tabpanel"
>                  data-localization-bundle="devtools/client/locales/inspector.properties">
> -        <div id="computedview-toolbar" class="devtools-toolbar">
> +        <div id="computed-toolbar" class="devtools-toolbar">
>            <div class="devtools-searchbox has-clear-btn">
>              <input id="computedview-searchbox"

for consistency shouldn't we computedview-searchbox -> computed-searchbox

::: devtools/client/inspector/inspector.xhtml:126
(Diff revision 1)
>            <div class="devtools-searchbox has-clear-btn">
>              <input id="computedview-searchbox"
>                          class="devtools-filterinput devtools-rule-searchbox"
>                          type="search"
>                          data-localization="placeholder=inspector.filterStyles.placeholder"/>
>              <button id="computedview-searchinput-clear" class="devtools-searchinput-clear"></button>

same comment

::: devtools/client/themes/computed.css:213
(Diff revision 1)
> -.link,
> -.helplink,
> +.computed-link,
> +.computed-link:visited {

This ruleset can now be merged with the one above

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1386108.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ed4bccae615
Update Computed stylesheet to use more specific selectors. r=jdescottes

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4ed4bccae615