Closed Bug 1386143 Opened 7 years ago Closed 7 years ago

Intermittent TEST-UNEXPECTED-PASS | /webrtc/RTCPeerConnection-onnegotiationneeded.html | negotiationneeded event should not fire if signaling state is not stable - expected FAIL

Categories

(Core :: WebRTC, defect, P5)

defect

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: intermittent-bug-filer, Assigned: drno)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:other])

Attachments

(1 file)

this test has increased in frequency on August 5th and has been up/down since then- failures are on debug mode, primarily on linux and osx.

here is a log for a recent osx failure:
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=124832634

in the above log I see an assertion:
04:18:17     INFO - PID 1619 | Assertion failure: mLength > 0 (|First()| called on an empty string), at /home/worker/workspace/build/src/xpcom/string/nsTSubstring.cpp:755

please note, that might not be related to the test failure, but worth mentioning just in case.  The crash we see here is on shutdown shortly after the assertion.

:mreavy, I see you are listed as the triage for webrtc tests- could you help find the right person to look at this in the near future?
Flags: needinfo?(mreavy)
Whiteboard: [stockwell needswork]
Nils -- Can you look into this failure?  Or find someone who can?  (Note: the assertions are irrelevant.)
Flags: needinfo?(mreavy) → needinfo?(drno)
*sigh* another case of broken WPT tests...
Flags: needinfo?(drno)
Assignee: nobody → drno
Rank: 25
Priority: P5 → P2
Note: I submitted the same patch upstream here https://github.com/w3c/web-platform-tests/pull/7001
(In reply to Nils Ohlmeier [:drno] from comment #8)
> Note: I submitted the same patch upstream here
> https://github.com/w3c/web-platform-tests/pull/7001

And it got already merged.
Attachment #8900940 - Flags: review?(jib)
Comment on attachment 8900940 [details]
Bug 1386143: fix WPT PeerConnection.onnegotiationneeded tests

https://reviewboard.mozilla.org/r/172388/#review178264

Except for the "offerToReceiveAudio" bit, the other changes here are unnecessary. It may be better to leave them alone since they detected bug 1394072.
Attachment #8900940 - Flags: review?(jib) → review-
Mass change P2->P3 to align with new Mozilla triage process.
Priority: P2 → P3
Bulk priority update of open intermittent test failure bugs. 

P3 => P5

https://bugzilla.mozilla.org/show_bug.cgi?id=1381960
Priority: P3 → P5
this hasn't failed in 3+ weeks, can we resolve this bug?
Flags: needinfo?(drno)
Whiteboard: [stockwell needswork] → [stockwell fixed:other]
I'm pretty sure the landing of upstream changes in bug 1397215 included my fixes.

The bad news is that :jib convinced me that my patch is/was wrong. So now we need to fix upstream, but that is not for this bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(drno)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: