Closed
Bug 1386158
Opened 7 years ago
Closed 7 years ago
Atom table is not thread-safe
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
DUPLICATE
of bug 1381731
People
(Reporter: xidorn, Unassigned)
References
Details
Attachments
(1 file)
|
1.40 KB,
patch
|
Details | Diff | Splinter Review |
The gUnusedAtomCount mechanism is not thread-safe, and there could be race condition when there is concurrency. This causes the two intermittents.
|
Reporter | |
Comment 1•7 years ago
|
||
This patch adds a gtest which makes this issue easy to reproduce.
Apply the patch, and run
> ./mach gtest 'Atoms.ConcurrentAccessing'
it should crash pretty reliably with "gUnusedAtomCount > 0".|
|
Reporter | |
Comment 2•7 years ago
|
||
with "Assertion failure: gUnusedAtomCount > 0", I mean.
|
|
Reporter | |
Comment 3•7 years ago
|
||
Stylo uses atoms heavily, concurrently. So this really should block stylo-release.
Blocks: stylo-release
|
|
Reporter | |
Comment 4•7 years ago
|
||
OK, heycam has some idea in bug 1381731.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•