1386188 - Support filter in layers-free mode

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

It may be more complicated than mask since we need to take care the fallback case. For fallback case, all child items should use fallback path too with the same gfxContext.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Bug 1386188 - Support filter for layers-free mode.

Review commit: https://reviewboard.mozilla.org/r/163796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163796/

Comment 2

[Ethan Lin[:ethlin]]

I skip the fallback path for now since nsDisplayWrapList's fallback is really annoying. Recently we are converting container type display items. I think we could turn back to see this issue when we have more experience. Probably only nsDisplayFilter needs the fallback. Then we could investigate further if there are other ways to solve the problem.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8892814 [details]
Bug 1386188 - Support filter for layers-free mode.

https://reviewboard.mozilla.org/r/163796/#review169256

Comment 4

[Ethan Lin[:ethlin]]

try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b89497913f64e7bcda14c61d4921c4c70d1051a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4020e23649ea
Support filter for layers-free mode. r=kats

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out bug 1386188 and bug 1386553 for Windows bustage at layers/StackingContextHelper.h(50):

bug 1386553: https://hg.mozilla.org/integration/mozilla-inbound/rev/2d2160acc177f73964ccb3b0e31f6d47e29d69ee
bug 1386188: https://hg.mozilla.org/integration/mozilla-inbound/rev/d4279fac29b123067e76a48cb4bdac81d05f1d21

Push with bustage: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=4020e23649ea04d90a308197b53af4ad3ad3932f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel
Build log: https://treeherder.mozilla.org/logviewer.html#?job_id=120632565&repo=mozilla-inbound

07:42:35     INFO -  Unified_cpp_gfx_layers11.cpp
07:42:35     INFO -  z:\build\build\src\obj-firefox\dist\include\mozilla/layers/StackingContextHelper.h(50): error C2061: syntax error: identifier 'nsDisplayListBuilder'
07:42:35     INFO -  z:/build/build/src/gfx/layers/wr/StackingContextHelper.cpp(76): error C2511: 'mozilla::layers::StackingContextHelper::StackingContextHelper(const mozilla::layers::StackingContextHelper &,mozilla::wr::DisplayListBuilder &,nsDisplayListBuilder *,nsDisplayItem *,nsDisplayList *,mozilla::gfx::Matrix4x4Typed<mozilla::LayerPixel,mozilla::LayerPixel> *,uint64_t,float *,mozilla::gfx::Matrix4x4 *,const nsTArray<mozilla::wr::WrFilterOp> &,const mozilla::gfx::CompositionOp &)': overloaded member function not found in 'mozilla::layers::StackingContextHelper'
07:42:35     INFO -  z:\build\build\src\obj-firefox\dist\include\nsDisplayList.h(63): note: see declaration of 'mozilla::layers::StackingContextHelper'
07:42:35     INFO -  z:/build/build/src/gfx/layers/wr/StackingContextHelper.cpp(77): error C2550: 'mozilla::layers::StackingContextHelper::{ctor}': constructor initializer lists are only allowed on constructor definitions
07:42:35     INFO -  z:/build/build/src/gfx/layers/wr/StackingContextHelper.cpp(92): error C2597: illegal reference to non-static member 'mozilla::layers::StackingContextHelper::mTransform'
07:42:35     INFO -  z:/build/build/src/gfx/layers/wr/StackingContextHelper.cpp(95): error C2227: left of '->PushStackingContext' must point to class/struct/union/generic type
07:42:35     INFO -  z:/build/build/src/gfx/layers/wr/StackingContextHelper.cpp(103): error C2597: illegal reference to non-static member 'mozilla::layers::StackingContextHelper::mOrigin'
07:42:35     INFO -  z:/build/build/src/config/rules.mk:1050: recipe for target 'Unified_cpp_gfx_layers11.obj' failed
07:42:35     INFO -  mozmake.EXE[5]: *** [Unified_cpp_gfx_layers11.obj] Error 2

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/99055838c65f
Support filter for layers-free mode. r=kats

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/99055838c65f