1386197 - (Mac) Opening the Bookmarks menu whilst the Library window is open causes recently bookmarked listener to remain which can impact performance

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Mark Banner (:standard8)]

I noticed this whilst having a general look at the performance of removing bookmarks.

STR:
- Open the Library window
- Set up a folder with a lot of bookmarks (e.g. ~600ish)
- Open and close the bookmarks menu
- Set up the profiler
- Delete the newly created folder.

Look at the profile -> There's lots of references to _populateRecentBookmarks and that takes a long time.

It only occurs on Mac, due to how the context menus work (Mac doesn't have context menus on the toolbar menus).

This bug was caused by bug 1248268 - it added an option for hiding or showing the recent items. However, in the Library window, the context items are not there.

As a result, attempting to deal with updating the context menu causes an exception and the listeners don't get removed.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1386197 - Show/Hide recently bookmarked menuitems don't exist in the Library window on Mac, handle the case so to avoid exceptions stopping listeners being removed.

Review commit: https://reviewboard.mozilla.org/r/163356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163356/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8892406 [details]
Bug 1386197 - Show/Hide recently bookmarked menuitems don't exist in the Library window on Mac, handle the case so to avoid exceptions stopping listeners being removed.

https://reviewboard.mozilla.org/r/163356/#review168770

Good catch

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ca999961054
Show/Hide recently bookmarked menuitems don't exist in the Library window on Mac, handle the case so to avoid exceptions stopping listeners being removed. r=mak

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2ca999961054