If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Display "junk" field keys better in report index

VERIFIED FIXED

Status

Socorro
Webapp
VERIFIED FIXED
2 months ago
2 months ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

2 months ago
If you have PII access and view the Metadata tab on report index, if any field is enormous due to crazy non-ascii keys, make that better.
(Assignee)

Updated

2 months ago
Assignee: nobody → peterbe
(Assignee)

Comment 1

2 months ago
To make this work easier I ported a couple of crash IDs from prod (see https://bugzilla.mozilla.org/show_bug.cgi?id=1382727#c6) that have crazy keys within:

https://crash-stats.allizom.org/report/index/3d640d71-2348-4ba8-9bf4-ee1b80170724 u'\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\
https://crash-stats.allizom.org/report/index/0fa1ad06-d09a-4446-9330-6a37b0170725 TotalPh{sicalMemory
https://crash-stats.allizom.org/report/index/04834613-a1b6-49a2-9bb2-d5a5b0170731 u''
https://crash-stats.allizom.org/report/index/c417284a-3173-4c63-a7f1-660a90170728 u'\\n\x1a\\n, Stride: 270 (t'
https://crash-stats.allizom.org/report/index/109c9291-4b2d-4a61-9da1-4cf260170725 u'\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd\ufffd...
https://crash-stats.allizom.org/report/index/cdc09b3c-b1ef-45ca-8c3d-331f90170722 u'"BIO\x0c\ufffdQCn5$3\t\ufffd\ufffd^Y\ufffdD6'

The more I think about it, the only "harm" of having these keys displayed is if they're crazy long or empty. We can do something about that in the HTML.
(Assignee)

Comment 2

2 months ago
PR https://github.com/mozilla-services/socorro/pull/3879

Comment 3

2 months ago
Commit pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/5326d9f4950a873cc1a2798710256cbd33b614e0
fixes bug 1386237 - Display "junk" field keys better in report index (#3879)

Updated

2 months ago
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
(Assignee)

Updated

2 months ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.