If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Don't suggest legacy addons from the collaborati filtering recommendations

RESOLVED FIXED

Status

Data Platform and Tools
General
P1
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: Dexter, Assigned: Dexter)

Tracking

(Blocks: 1 bug)

Details

(Whiteboard: [measurement:client])

Attachments

(2 attachments)

(Assignee)

Description

2 months ago
We should check that [1] doesn't recommend legacy addons, but just signed web extensions. If it does, we should change it.

[1] - https://github.com/mozilla/telemetry-batch-view/blob/master/src/main/scala/com/mozilla/telemetry/ml/AddonRecommender.scala
(Assignee)

Updated

2 months ago
Blocks: 1286215
Whiteboard: [measurement:client]
(Assignee)

Comment 1

2 months ago
After discussing this on #AMO, it turns out we can change the AMODatabase scala code [1] to also dump the |is_webextension| property for every addon. If the listed addon type is an "extension" and the |is_webextension| is false, then it's a legacy addon. 

Other addon types will continue to be legacy addons (e.g. "search", "language", "dictionary" types).

[1] - https://github.com/mozilla/telemetry-batch-view/blob/master/src/main/scala/com/mozilla/telemetry/ml/AMODatabase.scala
[2] - http://addons-server.readthedocs.io/en/latest/topics/api/addons.html#version-detail
(Assignee)

Updated

2 months ago
Assignee: nobody → alessio.placitelli
(Assignee)

Updated

2 months ago
Priority: -- → P1
(Assignee)

Comment 2

2 months ago
Created attachment 8892944 [details] [review]
Part 1 - Add the isWebextension to the recommender output
(Assignee)

Comment 3

2 months ago
Created attachment 8893242 [details] [review]
Part 2 - Use isWebextension from TAAR
(Assignee)

Comment 4

2 months ago
This was reviewed and merged.
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.