Closed Bug 138627 Opened 22 years ago Closed 22 years ago

mktemp() warnings when building ldapsearch.exe

Categories

(Directory :: LDAP Tools, defect, P2)

Product:
Directory
Component:
LDAP Tools
Platform:
x86
Windows 2000
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mcs, Assigned: mcs)

Details

Attachments

(1 file)

proposed fix
4.16 KB, patch
Details | Diff | Splinter Review 
When building ldapsearch.exe, a warning about mktemp() not being defined is
produced. This should be fixed. The build is actually picking up mktemp() from
nss3.dll; we should use _mktemp() from the Win32 C runtime DLL instead.
Status: NEW → ASSIGNED
Priority: -- → P2
Attached patch proposed fix — — Splinter Review 
Of course I have a patch... really simple. Please review.
Looks good.
Fix committed to the trunk:

mozilla/directory/c-sdk/ldap/clients/tools/ldapcmp.c
  new revision: 5.1; previous revision: 5.0
mozilla/directory/c-sdk/ldap/clients/tools/ldapsearch.c
  new revision: 5.1; previous revision: 5.0
mozilla/directory/c-sdk/ldap/clients/tools/ldaptool.h
  new revision: 5.2; previous revision: 5.1
    Fix bug # 138627 - mktemp() warnings when building ldapsearch.exe.
        Use _mktemp() on Windows.
    Remove a couple of unused local variables.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Spam for bug 129472
QA Contact: nobody → nobody
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: