Closed
Bug 1386298
Opened 7 years ago
Closed 4 years ago
Remove GCTrace framework and analysis tool
Categories
(Core :: JavaScript: GC, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla78
Tracking | Status | |
---|---|---|
firefox78 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(2 files)
54.98 KB,
patch
|
Details | Diff | Splinter Review | |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Back in bug 1028246 I added this tracing framework to dump all GC events and analyse them offline so we could work out whether there were opportunities to improve generational GC. I'm pretty sure this hasn't been used since and doubt it even compiles. We should just remove it.
Attachment #8892482 -
Flags: review?(sphink)
Assignee | ||
Comment 1•7 years ago
|
||
Comment on attachment 8892482 [details] [diff] [review] remove-gctrace It looks like this might still be useful, so cancelling review request for now.
Attachment #8892482 -
Flags: review?(sphink)
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Updated•4 years ago
|
Assignee: jcoppeard → nobody
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → jcoppeard
Assignee | ||
Comment 2•4 years ago
|
||
The tracing framework is unused but Matthew found the hook points useful, so this changes those into empty inline functions that can be used to insert probes.
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d450a08e761c Replace the unused GCTrace framework r=sfink
Comment 4•4 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•