1386319 - we seriously need to fix our notifications system for releases

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement, P1)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

Something is wrong. We really need to fix a bunch of issues.
a) "scheduled" instead of "are available" that's tracked under bug 1379170 
b) we get "available" on the release channel for RC shipping to beta. We need to fix that urgently in order to stop scaring people off.

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Emails like: 

"firefox release 55.0 updates are available on the release channel now <EOM>" from https://tools.taskcluster.net/groups/0rKw_NbcTjKuroEEWveJmg/tasks/eRacZUyKTD6S-uqMnf2X0g/details should never happen for RC when shipping to beta!

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

mtabara> yeah. was thinking this morning about the notifications system. while we fix it, why get all the head when we can play sneaky a bit? :)
13:15:39 — jlorenzo doesn't remember why this task is here
13:16:22 <~mtabara> I'd assume because of https://github.com/mozilla-releng/releasetasks/blob/master/releasetasks/templates/desktop/emails/cdntest.yml.tmpl#L3 but am not sure
13:17:05 <~mtabara> s,head,heat
13:17:44 <jlorenzo> oh, there are 2 release channels 
13:17:47 <~mtabara> yeah
13:17:56 <jlorenzo> sounds good, then 
13:17:59 <~mtabara> I guess we need to put some more conditions there
New messages
13:18:26 <~mtabara> the variables are share with https://github.com/mozilla-releng/releasetasks/blob/master/releasetasks/templates/desktop/emails/final.yml.tmpl#L7
13:18:55 <~mtabara> so 'release channels' is correctly set to 'beta' and 'release' in this case. but for cdntest it should only be beta there.
13:19:04 <~mtabara> we can probably hack something dirty in the Jinja templates
13:19:13 <~mtabara> or we can do it nicer in the release runner or something
13:19:41 <~mtabara> *shared

Comment 3

[Rok Garbas [:garbas]]

I did a quick hack in Jinja templates here: https://github.com/mozilla-releng/releasetasks/pull/258
It clearly needs a review of the condition[1] is correct since I'm not sure what this should actually be.

[1] https://github.com/mozilla-releng/releasetasks/pull/258/files#diff-1936cc6c51a8639d154ddaa7999eb44dR8

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Rok Garbas [:garbas] from comment #3)
> I did a quick hack in Jinja templates here:
> https://github.com/mozilla-releng/releasetasks/pull/258
> It clearly needs a review of the condition[1] is correct since I'm not sure
> what this should actually be.
> 
> [1]
> https://github.com/mozilla-releng/releasetasks/pull/258/files#diff-
> 1936cc6c51a8639d154ddaa7999eb44dR8

@garbas I revisited this logic in the mean time and this is correct. For RC1 we currently have:
    beta
    beta-localtest
    release
    release-localtest
.. out of which we need to trim the release email.

For RC graph2, since it's being generated separately based on release-configs from this repo, doesn't contain beta, so it will only generate the
    release
    release-cdntest
emails which are both correct.
We just need unit tests here and we're all set.

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

PR landed and fixed the issue. No need to wait for the next RC at the end of September to confirm this. Will re-open then but it looks promising so far. I think we can close this for now.
Thanks :garbas for the help with this!