Closed Bug 138633 Opened 18 years ago Closed 17 years ago

Esc key should close element properties dialog.

Categories

(SeaMonkey :: UI Design, defect, minor)

x86
All
defect
Not set
minor

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: martin, Assigned: stdowa+bugzilla)

References

Details

(Keywords: polish)

Attachments

(1 file)

It's just a little thing, but I think that things would be improved if the Esc 
key should close the element properties dialog.

When I do web development, I frequently like to know the size of an image. It's 
great that you can right-click on it and get it's size, but I expect the dialog 
to go away if I press the escape key.
-> XP APPS
Assignee: Matti → blaker
Severity: minor → enhancement
Component: Browser-General → XP Apps: GUI Features
QA Contact: imajes-qa → paw
see similar bug 135945

Can't find a dupe, confirmed on Linux cvs today...
Severity: enhancement → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: polish
OS: Windows 2000 → All
-> sicking
Assignee: blaker → sicking
Attached patch patchSplinter Review
r=sicking, but get someone from the navigator team to sr this
-> me
Assignee: sicking → walk84
Would it be better to turn this into a <dialog>? You'd get all the right dialog
key functionality for free then.
*** Bug 186794 has been marked as a duplicate of this bug. ***
It's not going to be turned into a dialog.  There was another bug report, long
ago, that discussed that.  It was agreed that it was an info window and not a
dialog box.

Does the patch still work?
Neil, yes.
Comment on attachment 83835 [details] [diff] [review]
patch

Neil, do you have a bug# for the discussion?

jag/bz, can you r/sr?
Attachment #83835 - Flags: superreview?(bzbarsky)
Attachment #83835 - Flags: review?(jaggernaut)
Attachment #83835 - Flags: superreview?(bzbarsky) → superreview+
Comment on attachment 83835 [details] [diff] [review]
patch

r=jag
Attachment #83835 - Flags: review?(jaggernaut) → review+
-> fixed.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Verified fixed in 2003011405/WinNT, /WinXP, /Win98se
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
Component: XP Apps: GUI Features → UI Design
You need to log in before you can comment on or make changes to this bug.