Closed Bug 1386379 Opened 8 years ago Closed 8 years ago

releasewarrior needs some polishing in terms of RCs

Categories

(Release Engineering :: Release Automation, enhancement, P2)

Product:
Release Engineering
Component:
Release Automation
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mtabara, Assigned: garbas)

Details

(Whiteboard: [releaseduty])

Two quick things: 1. WNP doesn't show up for some reason in the WNP, although it's there in both .json and .md files. 2. we've got some conflicting values in the list for the RC. We have two signoffs and two publish to balrog (one for each beta/release). This means that if we say "release update firefox release-rc 55.0 --checkbox signoff" it'll mark both the steps as done. This is unacceptable. We need to dive into this to debug and fix.
3. "publish" comes before "signoff" in all templates. Ever since we turned the signoffs on, we first publish it (as in marking the human step as resolved) and then "signoff" on releng behalf.
Assignee: nobody → rgarbas
https://github.com/mozilla/releasewarrior/pull/105 above is the PR for this bug
Flags: needinfo?(mtabara)
(In reply to Rok Garbas [:garbas] from comment #2) > https://github.com/mozilla/releasewarrior/pull/105 > > above is the PR for this bug Commented in the PR. For reference, I'll paste my comment here as well: - We can remove `cdntest`, it's the same thing with `mirrors` and no template references it currently.x: - We can rename `localtest` to `candidates` since it's being used in Fennec templates only and we have already switched the emails to that regards - We need to reverse order between `signoff` and `publish` - `wnp` stays before `mirrors` - `beta` stays before `wnp` - we need to add a separate step called `betasignoff` in between `beta` and `wnp`. Following this reordering & cleanup, we need to also update *all* templates with the correct steps and order. `betasignoff` should replace existing `signoff` from release RC templates while `signoff2` should simply become `signoff`.
Flags: needinfo?(mtabara)
Priority: P3 → P2
(In reply to Rok Garbas [:garbas] from comment #2) > https://github.com/mozilla/releasewarrior/pull/105 > > above is the PR for this bug Sorry :garbas to have hijacked your PR but wanted to take advantage of the "no releases currently in flight" state to update releaswarrior. Things look good so far, will reopen if anything else comes up.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.