Closed
Bug 1386391
Opened 7 years ago
Closed 7 years ago
Intermittent docshell/test/navigation/test_sessionhistory.html | Should have loaded a new document
Categories
(Core :: DOM: Navigation, defect, P1)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla57
People
(Reporter: intermittent-bug-filer, Assigned: hchang)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:DOM][domsecurity-active])
Attachments
(1 file, 1 obsolete file)
Filed by: wkocher [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=119932807&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/bqj5EaqpR62Tni0sQR4GXQ/runs/0/artifacts/public/logs/live_backing.log
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 3•7 years ago
|
||
Looks like this frequent intermittent failure started with the changes for bug 1385981.
Blocks: 1385981
Flags: needinfo?(ckerschb)
Comment 4•7 years ago
|
||
I took at look at that test and the error message: - TEST-UNEXPECTED-FAIL | docshell/test/navigation/test_sessionhistory.html | Should have loaded a new document - testDone@docshell/test/navigation/file_fragment_handling_during_load.html:8:9 - setTimeout handler*test@docshell/test/navigation/file_fragment_handling_during_load.html:19:19 - setTimeout handler*onload@docshell/test/navigation/file_fragment_handling_during_load.html:1:1 This tests relies on a flaky timeout (predating our changes within Bug 1385981). I think because we are loading content from an external file instead of using a data: URI (see [1]) some of our old testing machines are not fast enough to load content before the timeout fires. Extending the timeout to 3000 should hopefully fix the issue. [1] https://hg.mozilla.org/mozilla-central/rev/46fcd660ce40#l1.22
Flags: needinfo?(ckerschb)
Attachment #8895277 -
Flags: review?(bugs)
Comment 5•7 years ago
|
||
I will be on PTO starting today. Henry is going to take over and drag this one over the finishing line. In case the patch doesn't fix the intermittent, Henry offered to take another look at the issue.
Assignee: nobody → hchang
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [stockwell needswork:DOM] → [stockwell needswork:DOM][domsecurity-active]
Comment 6•7 years ago
|
||
Comment on attachment 8895277 [details] [diff] [review] bug_1386391_intermittent_sessionhistory.patch We can try this.
Attachment #8895277 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 7•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9deae65a8dc1
Assignee | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee814fcc12d8
Assignee | ||
Comment 9•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4614c5f6fda
Assignee | ||
Comment 10•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9ddfc4d13d9
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 13•7 years ago
|
||
The patch doesn't seem to work according to https://treeherder.mozilla.org/logviewer.html#?job_id=122512012&repo=try&lineNumber=63905 I will need to dig deeper into this issue.
Comment hidden (mozreview-request) |
Comment 15•7 years ago
|
||
hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try searching for changes remote: abort: abandoned transaction found! remote: (run 'hg recover' to clean up transaction) abort: stream ended unexpectedly (got 0 bytes, expected 4)
Assignee | ||
Comment 16•7 years ago
|
||
Comment on attachment 8895277 [details] [diff] [review] bug_1386391_intermittent_sessionhistory.patch This patch doesn't work.
Attachment #8895277 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8896822 -
Flags: review?(bugs)
Assignee | ||
Comment 17•7 years ago
|
||
According to https://treeherder.mozilla.org/#/jobs?repo=try&revision=5142782a73c73d124d91741d86e0be833c199e99 It seems my patch works well and the solution is fairly straightforward so I am confident to ask :smaug for a review. [1] https://reviewboard.mozilla.org/r/168112/
Comment 18•7 years ago
|
||
mozreview-review |
Comment on attachment 8896822 [details] Bug 1386391 - Poll to check if a document has loaded rather than a definite timeout. https://reviewboard.mozilla.org/r/168114/#review173388
Attachment #8896822 -
Flags: review?(bugs) → review+
Comment hidden (Intermittent Failures Robot) |
Comment 20•7 years ago
|
||
Pushed by hchang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2cca20fca12c Poll to check if a document has loaded rather than a definite timeout. r=smaug
Comment 21•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2cca20fca12c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 22•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/36c4a1d0b3be
status-firefox56:
--- → fixed
Flags: in-testsuite+
Whiteboard: [stockwell needswork:DOM][domsecurity-active] → [stockwell fixed:DOM][domsecurity-active]
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•