1386402 - Change mar generation scripts to exit with an error if xz is not found on the system

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Robert Strong (they/them - no direct email)]

Over irc catlee asked for this.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/46d7ac61d7cc
Change mar generation scripts to exit with an error if xz is not found on the system. r=bhearsum

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 8892630 [details] [diff] [review]
patch

This is for a build script so this request might not be necessary.

Approval Request Comment
[Feature/Bug causing the regression]: The check for the executable that compresses mar files never existed but now that we changed to using xz it is a good thing to have this check since our build systems are less likely to have xz installed.
[User impact if declined]: None
[Is this code covered by automated tests?]: None
[Has the fix been verified in Nightly?]: Will be used to generate updates today.
[Needs manual test from QE? If yes, steps to reproduce]: N/A
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: It is for a build script
[String changes made/needed]: None

Comment 4

[Robert Strong (they/them - no direct email)]

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #3)
> Comment on attachment 8892630 [details] [diff] [review]
> patch
> 
> This is for a build script so this request might not be necessary.
> 
> Approval Request Comment
> [Feature/Bug causing the regression]: The check for the executable that
> compresses mar files never existed but now that we changed to using xz it is
> a good thing to have this check since our build systems are less likely to
> have xz installed.
> [User impact if declined]: None
> [Is this code covered by automated tests?]: None
> [Has the fix been verified in Nightly?]: Will be used to generate updates
> today.
Actually, this hasn't been merged to m-c yet and it will be used to generate updates after it has been merged.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/46d7ac61d7cc

Comment 6

[Liz Henry (:lizzard)]

Do we still need to uplift this for beta 1?

Comment 7

[Robert Strong (they/them - no direct email)]

Not for beta 1. This should land at the same time as the other server side mar generation scripts in Bug 1387241.

Comment 8

[Liz Henry (:lizzard)]

Noting this (and the work in bug 1387241) is now waiting to land after we build beta 3. Not for beta 3.

Comment 9

[Liz Henry (:lizzard)]

Comment on attachment 8892630 [details] [diff] [review]
patch

Needed for 56 beta 3 to beta 4 watershed/migration to 64-bit.

Comment 10

[Robert Strong (they/them - no direct email)]

Landed on mozilla-beta
https://hg.mozilla.org/releases/mozilla-beta/rev/d95e1a324228b51db76c9e2e545c93abba9bb72a