Fix some error handling in StripHandlerFromOBJREF

RESOLVED FIXED in Firefox 57

Status

()

Core
Disability Access APIs
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: aklotz, Assigned: aklotz)

Tracking

Trunk
mozilla57
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
We should distinguish between "I have failed to read the OBJREF type" vs "this OBJREF type does not require us to make any changes"
(Assignee)

Comment 1

a year ago
Created attachment 8892654 [details] [diff] [review]
Patch

This patch ensures that we return true from StripHandlerFromOBJREF when the OBJREF does not supply a handler.

This patch also modifies the postcondition of StripHandlerFromOBJREF such that, whenever the function returns true, the stream is always positioned back to the end of the OBJREF.
Attachment #8892654 - Flags: review?(jmathies)
(Assignee)

Comment 2

a year ago
Created attachment 8892738 [details] [diff] [review]
Patch (r2)

This patch ensures that we return true from StripHandlerFromOBJREF when the OBJREF does not include a handler (since there is nothing that it needs to do).

This patch also modifies the postcondition of StripHandlerFromOBJREF such that, whenever the function returns true, the stream is always positioned back to the end of the OBJREF.
Attachment #8892654 - Attachment is obsolete: true
Attachment #8892654 - Flags: review?(jmathies)
Attachment #8892738 - Flags: review?(jmathies)

Updated

a year ago
Attachment #8892738 - Flags: review?(jmathies) → review+
(Assignee)

Comment 3

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d8f6382c8d0241712b735646a1d891bf83bb27d
Bug 1386422: Clean up error handling and stream positioning in StreamHandlerFromOBJREF; r=jimm
https://hg.mozilla.org/mozilla-central/rev/6d8f6382c8d0
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.