Turning on the 'layout.display-list.dump-content' may cause crash in layers-free mode

RESOLVED FIXED in Firefox 57

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: ethlin, Assigned: ethlin)

Tracking

(Blocks: 1 bug)

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
That's because we should check if the root is nullptr at[1].

[1] https://dxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.cpp#3789
Comment hidden (mozreview-request)
(In reply to Ethan Lin[:ethlin] from comment #0)
> [1]
> https://dxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.
> cpp#3789

Please use permalinks when linking to code in bugs. This link is already out of date.

Comment 3

9 months ago
mozreview-review
Comment on attachment 8892721 [details]
Bug 1386477 - Add nullptr check for layerManager->GetRoot() to prevent crash when dumping display list data.

https://reviewboard.mozilla.org/r/163716/#review169226
Attachment #8892721 - Flags: review?(bugmail) → review+
(Assignee)

Comment 4

9 months ago
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2)
> (In reply to Ethan Lin[:ethlin] from comment #0)
> > [1]
> > https://dxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.
> > cpp#3789
> 
> Please use permalinks when linking to code in bugs. This link is already out
> of date.

Okay, I will use permalinks next time, like this: https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/layout/base/nsLayoutUtils.cpp#3796.

Comment 5

9 months ago
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/787a68a754f2
Add nullptr check for layerManager->GetRoot() to prevent crash when dumping display list data. r=kats
Blocks: 1386674

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/787a68a754f2
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.