1386477 - Turning on the 'layout.display-list.dump-content' may cause crash in layers-free mode

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

That's because we should check if the root is nullptr at[1].

[1] https://dxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.cpp#3789

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Bug 1386477 - Add nullptr check for layerManager->GetRoot() to prevent crash when dumping display list data.

Review commit: https://reviewboard.mozilla.org/r/163716/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163716/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

(In reply to Ethan Lin[:ethlin] from comment #0)
> [1]
> https://dxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.
> cpp#3789

Please use permalinks when linking to code in bugs. This link is already out of date.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8892721 [details]
Bug 1386477 - Add nullptr check for layerManager->GetRoot() to prevent crash when dumping display list data.

https://reviewboard.mozilla.org/r/163716/#review169226

Comment 4

[Ethan Lin[:ethlin]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)
> (In reply to Ethan Lin[:ethlin] from comment #0)
> > [1]
> > https://dxr.mozilla.org/mozilla-central/source/layout/base/nsLayoutUtils.
> > cpp#3789
> 
> Please use permalinks when linking to code in bugs. This link is already out
> of date.

Okay, I will use permalinks next time, like this: https://dxr.mozilla.org/mozilla-central/rev/52285ea5e54c73d3ed824544cef2ee3f195f05e6/layout/base/nsLayoutUtils.cpp#3796.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/787a68a754f2
Add nullptr check for layerManager->GetRoot() to prevent crash when dumping display list data. r=kats

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/787a68a754f2