1386496 - Ahem.ttf is broken on web-platform-tests

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[Makoto Kato [:m_kato]]

Ahem.ttf is copied to $(DIST)/bin/firefox/fonts, but this file is broken due to text mode copy.

Comment 1

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af9d8acce43092693e05e9795f07c6c716799c6b

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1386496 - Ahem.ttf is broken on web-platform-tests.

Ahem.ttf is copied to $(DIST)/bin/firefox/fonts, but this file is broken due to text mode copy.  So we should use binary mode instead.

Review commit: https://reviewboard.mozilla.org/r/163734/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163734/

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1386496 - Update web-platfrom-tests meta data after Ahem.ttf is valid.

Since Ahem.ttf is valid now, we should pass wbr-element.html on Windows.
Also, mac doesn't pass this test because MOZ_BUNDLED_FONTS isn't set on macOS build.

Review commit: https://reviewboard.mozilla.org/r/163736/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163736/

Comment 4

[James Graham [:jgraham]]

Comment on attachment 8892744 [details]
Bug 1386496 - Ahem.ttf is broken on web-platform-tests.

https://reviewboard.mozilla.org/r/163734/#review169132

Comment 5

[James Graham [:jgraham]]

Comment on attachment 8892745 [details]
Bug 1386496 - Update web-platfrom-tests meta data after Ahem.ttf is valid.

https://reviewboard.mozilla.org/r/163736/#review169134

This change looks fine, but I'm pretty sure it won't be the only file that needs updating, so please run |mach try -p linux,linux64,macosx64,win32,win64 -u web-platform-tests-reftests[linux64-stylo,Ubuntu,10.10,Windows 7,Windows 8,Windows 10]| and see what else needs to change (I can help with the metadata updates if required).

Also, thank you for fixing this! Do you have any suggestions for how to enable Ahem on Mac? Do I just need to work with releng to update the machine images, or is there some way to bundle it?

Comment 6

[Makoto Kato [:m_kato]]

(In reply to James Graham [:jgraham] from comment #5)
> Comment on attachment 8892745 [details]
> Bug 1386496 - Update web-platfrom-tests meta data after Ahem.ttf is valid.
> 
> https://reviewboard.mozilla.org/r/163736/#review169134
> 
> This change looks fine, but I'm pretty sure it won't be the only file that
> needs updating, so please run |mach try -p
> linux,linux64,macosx64,win32,win64 -u
> web-platform-tests-reftests[linux64-stylo,Ubuntu,10.10,Windows 7,Windows
> 8,Windows 10]| and see what else needs to change (I can help with the
> metadata updates if required).
> 
> Also, thank you for fixing this! Do you have any suggestions for how to
> enable Ahem on Mac? Do I just need to work with releng to update the machine
> images, or is there some way to bundle it?

If we want to pass this test on macOS, we require MOZ_BUNDLED_FONTS=1 on browser/confvars.sh.  This option on other platforms (Windows and Linux) is enabled when bundling EmojiOne font on Windows 7 and Linux.  Since Mac already have emoji color font, we don't turn on it.

Comment 7

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdc06b6f6e39f5f8b2d4da7c8edc33c3215c9390

Comment 8

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfd2b40034ffc65fce5917125453e770bbf5643f

Comment 9

[Makoto Kato [:m_kato]]

Humm, m-c's repository is corrupted (changeset 52285ea5e54c), so rebase this, then submit try again.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ff0d150af979bc54f6e08c7d9fb2c1889bc25914

Comment 10

[Makoto Kato [:m_kato]]

Comment on attachment 8892745 [details]
Bug 1386496 - Update web-platfrom-tests meta data after Ahem.ttf is valid.

Could you review again?

try is passed.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=773ff31583c4ae48b95c96198e6d61b290647b7e

Comment 11

[Makoto Kato [:m_kato]]

Comment on attachment 8892745 [details]
Bug 1386496 - Update web-platfrom-tests meta data after Ahem.ttf is valid.

Ah, mac jobs doesn't start.  I clear flag to wait it.

Comment 12

[James Graham [:jgraham]]

Comment on attachment 8892745 [details]
Bug 1386496 - Update web-platfrom-tests meta data after Ahem.ttf is valid.

https://reviewboard.mozilla.org/r/163736/#review169632

Comment 13

[James Graham [:jgraham]]

Given the problems with OSX on try I'm happy to land this as is, and assume it will pass on OSX (please go back and cancel those jobs :)

Comment 14

[Makoto Kato [:m_kato]]

I pass OSX's WPT.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1bf496f3608c
Ahem.ttf is broken on web-platform-tests. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/dc75242f84a4
Update web-platfrom-tests meta data after Ahem.ttf is valid. r=jgraham

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/1bf496f3608c
https://hg.mozilla.org/mozilla-central/rev/dc75242f84a4

Comment 17

[Aki Sasaki (not active)]

https://hg.mozilla.org/projects/date/rev/1bf496f3608caa47ffdc428801883fc199e49280
Bug 1386496 - Ahem.ttf is broken on web-platform-tests. r=jgraham

https://hg.mozilla.org/projects/date/rev/dc75242f84a4faf86dbfdb5c6d0bc86b80d79ac7
Bug 1386496 - Update web-platfrom-tests meta data after Ahem.ttf is valid. r=jgraham