Closed Bug 1386517 Opened 7 years ago Closed 7 years ago

Don't flush async paints on the main thread

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Version:
40 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: dvander, Assigned: dvander)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

fix
2.29 KB, patch
mattwoodrow
: review+
Details | Diff | Splinter Review 
Currently TextureClient::Unlock does some operations on DrawTargets that are definitely not safe during async painting. It calls Flush, and detaches all snapshots. OMTP already handles the former, maybe it should just assert that there are no snapshots for the latter.
Attached patch fix — — Splinter Review 

        Attachment #8892748 -
        Flags: review?(matt.woodrow)

        Attachment #8892748 -
        Flags: review?(matt.woodrow) → review+

    
    

    
  
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4047292ad65c
Don't flush async paints on the main thread. (bug 1386517, r=mattwoodrow)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/4047292ad65c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox57:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: