Edit comment to stop false-positiveing for sdk/ usages in debounce.js file

RESOLVED FIXED in Firefox 57

Status

enhancement
P1
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: sole, Assigned: ikram)

Tracking

({good-first-bug})

unspecified
Firefox 57
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [reserve-nosdk])

Attachments

(1 attachment)

The comment in the header of devtools/shared/debounce.js mentions a SDK path, which triggers a false positive for bug 1350645 which consists on removing usages of the SDK: http://searchfox.org/mozilla-central/source/devtools/shared/debounce.js#13

We should replace:

from "sdk/lang/functional/concurrent.js"

into

from the SDK's "lang/functional/concurrent.js"

so it's still crediting the source, but doesn't trigger the positive on the search we're using: https://bugzilla.mozilla.org/show_bug.cgi?id=1350645#c12
Whiteboard: [nosdk]
Flags: qe-verify?
Priority: -- → P3
Whiteboard: [nosdk] → [reserve-nosdk]
I am trying to fix this one :) Hence, assigning myself.
Assignee: nobody → hossainalikram
Status: NEW → ASSIGNED
Priority: P3 → P1
Target Milestone: --- → Firefox 57
Submitting this as patch. Let me know, If i should modify something :)
Attachment #8894092 - Flags: review?(spenades)
Comment on attachment 8894092 [details] [diff] [review]
edited-comment.patch

Thank you Hossain! That was fast :)

This looks good to me. I'll request it be merged.
Attachment #8894092 - Flags: review?(spenades) → review+
Keywords: checkin-needed
Whiteboard: [reserve-nosdk] → [reserve-nosdk] check
Whiteboard: [reserve-nosdk] check → [reserve-nosdk]
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89cfa36b6fda
Edit comment to stop false-positiveing for sdk/ usages in debounce.js file. r=sole
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/89cfa36b6fda
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Iteration: --- → 57.1 - Aug 15
https://hg.mozilla.org/projects/date/rev/89cfa36b6fdac80427003414befe9264d6d98013
Bug 1386545 - Edit comment to stop false-positiveing for sdk/ usages in debounce.js file. r=sole
Flags: qe-verify? → qe-verify-
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.