1386567 - "Restore Defaults" should restore default pageActions icons in Address Bar

Status: NEW

(Firefox :: Toolbars and Customization, defect, P4)

Description

[Alice0775 White]

Reproducible : always

Steps To Reproduce:
[Prepare, remove/add icon in Address Bar]
Click the three dots "..." to show the menu, 
Right-click on item and choose "Remove from Address Bar" or "Add to Address Bar".

1. Enter Customize mode(menu > Customize...)
2. Click "Restore Defaults" and then "Done"

Actual Results:
Icon in Address Bar does not change anything.

Expected Results:
Icon in Address Bar should be restored default set(i.e, only star icon)

Comment 1

[Tim Nguyen :ntim]

I wonder if this should be done.

It would make a lot of sense if page actions were customizable from about:customizing, but not sure it makes sense in this case where about:customizing isn't involved in the process.

Comment 2

[:Gijs (he/him)]

I'm ambivalent about doing this. Although comment #1 offers reasons against, arguably this is another form of toolbar customization, and certainly affects available space in the navbar. Also, density changes (how do those work when automatically made by using win10 tablet mode?), toolbar visibility changes (even if made outside customize mode), add-ons added outside of customize mode, and theme changes (even if not made through customize mode, though they could be made there, of course) all get reset. So it equally doesn't seem unreasonable to want these changes to revert, too.

Anyway, definitely not required for shipping this, especially not once the context menus are available on the url bar, too.

Comment 3

[Ryan Feeley [:rfeeley]]

I almost filed this myself. It's certainly a form of customization the user would expect to restore to its default position. How can they learn what our recommended defaults are if they're just playing around?

Comment 4

[Aaron Benson]

Until (or unless) we show the Page Action Menu inside customize mode then I'm inclined to not agree with this change. There's no way to see that that menu was affected and use the undo function. I'm not saying there shouldn't be a way to reset it but I don't think this is that way.