Closed Bug 1386584 Opened 7 years ago Closed 7 years ago

Stop using devtools shared/platform/chrome/stack module as a JSM

Categories

(DevTools :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(1 file)

See https://bugzilla.mozilla.org/show_bug.cgi?id=1386299#c3

After Bug 1386299 lands, we no longer need to keep the JSM boilerplate at the beginning of devtools/shared/platform/chrome/stack.js (http://searchfox.org/mozilla-central/source/devtools/shared/platform/chrome/stack.js) as it will only be loaded via require().
Comment on attachment 8892843 [details]
Bug 1386584 - Remove JSM boilerplate in devtools/shared/platform/chrome/stack;

https://reviewboard.mozilla.org/r/163860/#review169670
Attachment #8892843 - Flags: review?(poirot.alex) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17aff9906595
Remove JSM boilerplate in devtools/shared/platform/chrome/stack;r=ochameau
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/223e4179fdd1
Backed out changeset 17aff9906595 because bug 1386299 had to be backed out. r=backout on a CLOSED TREE
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1014c8e695a6
Remove JSM boilerplate in devtools/shared/platform/chrome/stack;r=ochameau
https://hg.mozilla.org/mozilla-central/rev/1014c8e695a6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
https://hg.mozilla.org/projects/date/rev/17aff9906595b6ec6351281257075c3b878207bd
Bug 1386584 - Remove JSM boilerplate in devtools/shared/platform/chrome/stack;r=ochameau

https://hg.mozilla.org/projects/date/rev/223e4179fdd11808f38f1d05134d823c41b4706e
Backed out changeset 17aff9906595 (bug 1386584) because bug 1386299 had to be backed out. r=backout on a CLOSED TREE

https://hg.mozilla.org/projects/date/rev/1014c8e695a6ea680917717b4caf9c8c26eab563
Bug 1386584 - Remove JSM boilerplate in devtools/shared/platform/chrome/stack;r=ochameau
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: