If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Miscellaneous toolchain tweaks, changes and cleanups

RESOLVED FIXED

Status

()

Core
Build Config
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(9 attachments)

59 bytes, text/x-review-board-request
gps
: review+
Details | Review
59 bytes, text/x-review-board-request
dustin
: review+
Details | Review
59 bytes, text/x-review-board-request
gps
: review+
Details | Review
59 bytes, text/x-review-board-request
gps
: review+
Details | Review
59 bytes, text/x-review-board-request
gps
: review+
Details | Review
59 bytes, text/x-review-board-request
gps
: review+
Details | Review
59 bytes, text/x-review-board-request
gps
: review+
Details | Review
59 bytes, text/x-review-board-request
gps
: review+
Details | Review
59 bytes, text/x-review-board-request
gps
: review+
Details | Review
Comment hidden (empty)
(Assignee)

Updated

2 months ago
Blocks: 1386589
(Assignee)

Updated

2 months ago
Blocks: 1356926
(Assignee)

Updated

2 months ago
Blocks: 1386610
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 10

2 months ago
mozreview-review
Comment on attachment 8892887 [details]
Bug 1386588 - Error out when a resource pattern for toolchains matches nothing.

https://reviewboard.mozilla.org/r/163898/#review169236

This will apply to docker images, too - consider adjusting the commit message?
Attachment #8892887 - Flags: review?(dustin) → review+

Comment 11

2 months ago
mozreview-review
Comment on attachment 8892886 [details]
Bug 1386588 - Rename the clang build manifests.

https://reviewboard.mozilla.org/r/163896/#review169378
Attachment #8892886 - Flags: review?(gps) → review+

Comment 12

2 months ago
mozreview-review
Comment on attachment 8892888 [details]
Bug 1386588 - Avoid wildcards in toolchain resources lists.

https://reviewboard.mozilla.org/r/163900/#review169380
Attachment #8892888 - Flags: review?(gps) → review+

Comment 13

2 months ago
mozreview-review
Comment on attachment 8892889 [details]
Bug 1386588 - Rename the linux64-clang and linux64-gcc jobs to include a version number.

https://reviewboard.mozilla.org/r/163902/#review169382
Attachment #8892889 - Flags: review?(gps) → review+

Comment 14

2 months ago
mozreview-review
Comment on attachment 8892890 [details]
Bug 1386588 - Change the GCC build script to be future-proof.

https://reviewboard.mozilla.org/r/163904/#review169384

Nice.

Regarding verifying downloaded files, I still prefer to embed the hash in the repo instead of using GPG. This has stronger guarantees than GPG signature verification because a compromised GPG key can sign anything and GPG signature verification would pass on any properly signed file. However, a SHA-512 hash will only ever match one file.
Attachment #8892890 - Flags: review?(gps) → review+

Comment 15

2 months ago
mozreview-review
Comment on attachment 8892891 [details]
Bug 1386588 - Add a toolchain job for GCC 4.8, and build clang against it.

https://reviewboard.mozilla.org/r/163906/#review169388
Attachment #8892891 - Flags: review?(gps) → review+

Comment 16

2 months ago
mozreview-review
Comment on attachment 8892892 [details]
Bug 1386588 - Add a toolchain job for GCC 6.

https://reviewboard.mozilla.org/r/163908/#review169390

\o/
Attachment #8892892 - Flags: review?(gps) → review+

Comment 17

2 months ago
mozreview-review
Comment on attachment 8892893 [details]
Bug 1386588 - Add a toolchain job for Clang 4.

https://reviewboard.mozilla.org/r/163910/#review169392
Attachment #8892893 - Flags: review?(gps) → review+

Comment 18

2 months ago
mozreview-review
Comment on attachment 8892894 [details]
Bug 1386588 - Always print out the commands run by the clang build job.

https://reviewboard.mozilla.org/r/163912/#review169394
Attachment #8892894 - Flags: review?(gps) → review+
(Assignee)

Comment 19

2 months ago
(In reply to Gregory Szorc [:gps] from comment #14)
> Comment on attachment 8892890 [details]
> Bug 1386588 - Change the GCC build script to be future-proof.
> 
> https://reviewboard.mozilla.org/r/163904/#review169384
> 
> Nice.
> 
> Regarding verifying downloaded files, I still prefer to embed the hash in
> the repo instead of using GPG. This has stronger guarantees than GPG
> signature verification because a compromised GPG key can sign anything and
> GPG signature verification would pass on any properly signed file. However,
> a SHA-512 hash will only ever match one file.

We're doing both, and we should keep doing both.

Comment 20

2 months ago
OK. Both is definitely better than just 1.

Comment 21

2 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/mozilla-central/rev/6090ee834fb3
Rename the clang build manifests. r=gps
https://hg.mozilla.org/mozilla-central/rev/69190404d80b
Error out when a resource pattern for toolchains matches nothing. r=dustin
https://hg.mozilla.org/mozilla-central/rev/9a82fd89dff9
Avoid wildcards in toolchain resources lists. r=gps
https://hg.mozilla.org/mozilla-central/rev/75d8fbca1a05
Rename the linux64-clang and linux64-gcc jobs to include a version number. r=gps
https://hg.mozilla.org/mozilla-central/rev/f204aac76f9f
Change the GCC build script to be future-proof. r=gps
https://hg.mozilla.org/mozilla-central/rev/25420b520b68
Add a toolchain job for GCC 4.8, and build clang against it. r=gps
https://hg.mozilla.org/mozilla-central/rev/7e43e6ed3afc
Add a toolchain job for GCC 6. r=gps
https://hg.mozilla.org/mozilla-central/rev/f87b29d9cf03
Add a toolchain job for Clang 4. r=gps
https://hg.mozilla.org/mozilla-central/rev/792d0a2e04d7
Always print out the commands run by the clang build job. r=gps,a=KWierso
(Assignee)

Updated

2 months ago
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
(Assignee)

Comment 22

2 months ago
I had to backout the part about building clang with gcc 4.8, because of asan bustage. Can't have nice things, right?

https://hg.mozilla.org/mozilla-central/rev/550c67a208b4

Fortunately, I found another way around the clang 3.9 problem in bug 1356926.

However, what this shows is that we can't necessarily blindly change the gcc version that builds clang, because of the libstdc++/libgcc changes that means. Which means we shouldn't use the toolchain alias, but an explicit toolchain name ; I'll file a new bug for that.

Comment 23

2 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/mozilla-central/rev/d942ef54fdf7
Fixup after backout of 25420b520b68 (part of bug 1386588). a=bustage

Comment 24

2 months ago
https://hg.mozilla.org/projects/date/rev/6090ee834fb345c2069c06147ec04deb2b287261
Bug 1386588 - Rename the clang build manifests. r=gps

https://hg.mozilla.org/projects/date/rev/69190404d80b855fa788845d5a9b81cd6df34ed4
Bug 1386588 - Error out when a resource pattern for toolchains matches nothing. r=dustin

https://hg.mozilla.org/projects/date/rev/9a82fd89dff95e2a87f7d3818179b9218e1feb1b
Bug 1386588 - Avoid wildcards in toolchain resources lists. r=gps

https://hg.mozilla.org/projects/date/rev/75d8fbca1a0579e4f9df8f370244379c2afbeac6
Bug 1386588 - Rename the linux64-clang and linux64-gcc jobs to include a version number. r=gps

https://hg.mozilla.org/projects/date/rev/f204aac76f9f395232ef111cb3fe9086ef1fee76
Bug 1386588 - Change the GCC build script to be future-proof. r=gps

https://hg.mozilla.org/projects/date/rev/25420b520b68e30a93025aee6407b38d76a9b755
Bug 1386588 - Add a toolchain job for GCC 4.8, and build clang against it. r=gps

https://hg.mozilla.org/projects/date/rev/7e43e6ed3afc703d76b718b2e128c9b923d13500
Bug 1386588 - Add a toolchain job for GCC 6. r=gps

https://hg.mozilla.org/projects/date/rev/f87b29d9cf03b4f9cfea4907ec6c841e57d185df
Bug 1386588 - Add a toolchain job for Clang 4. r=gps

https://hg.mozilla.org/projects/date/rev/792d0a2e04d7bc337c77f4777848337ac6ba6dd6
Bug 1386588 - Always print out the commands run by the clang build job. r=gps,a=KWierso

https://hg.mozilla.org/projects/date/rev/550c67a208b4b686ed66440562a93ce9e12d94ca
Backout changeset 25420b520b68 (part of bug 1386588) for asan bustage. a=bustage.

https://hg.mozilla.org/projects/date/rev/d942ef54fdf726840a698d2ddcaf989d2c00edbc
Fixup after backout of 25420b520b68 (part of bug 1386588). a=bustage
You need to log in before you can comment on or make changes to this bug.