1386598 - regression: check boxes are invisible

Status: RESOLVED DUPLICATE of bug 1396984

(Core :: Layout, defect)

Description

[tomaspartl]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/52.0
Build ID: 20170802100302

Steps to reproduce:

I opened a page that is supposed to display a check box: https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_checkbox_checked


Actual results:

The check box was invisible. You couldn't see it but if you clicked the place where you guessed it should be, it worked.


Expected results:

For the most superb user experience, the check box should have been visible!

Comment 1

[Darkspirit]

Attachment: Screenshot_20170802_144550.png

I can't reproduce this :(
The checkbox is visible in:
* Nightly 56 x64 20170801100311 DE @ Debian Testing
* Nightly 56 x64 20170801100311 DE @ Win 7 x64 (Win64)
* Nightly 56 x86 20170731175927 DE @ Win 7 x64 (WOW64)
* Nightly 56 x86 20170802100302 en_US @ Win 7 x64 (WOW64) <-- exactly your setup (see screenshot. It's also visible with a disabled tracking protection). 

As you are using a 32 bit Nightly on a 64 bit Win7 (=WOW64), I want to suggest you to download the 64 bit Version:
https://www.mozilla.org/de/firefox/nightly/all/

Comment 2

[Darkspirit]

Currently I would plead for marking this as WFM. Maybe anybody has an idea.

Comment 3

[Darkspirit]

Oops, sorry, I meant "somebody".

Comment 4

[Darkspirit]

Sorry, I meant "somebody" and wanted to give you this link: https://www.mozilla.org/firefox/nightly/all/

Comment 5

[tomaspartl]

I'm running Nightly 57.0a1 (2017-08-02) (64-bit) on Ubuntu 17.04 (4.4.0-83-generic #106-Ubuntu SMP Mon Jun 26 17:54:43 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux).

I just checked and the checkbox is visible in Firefox 54.0 (64 bit) but not in the Nightly.
Also, I discovered it stays invisible even if I turn of layout.css.servo.enabled , so I miscategorized it but it does seem like a Nightly bug.

Comment 6

[tomaspartl]

I meant "turn off" and I should add the FF 54.0 runs on the same system.

Comment 7

[Jeremy Chen ([e-mail])]

I can't reproduce this on Nightly 57.0a1 (20170802100302) on Ubuntu 16.04 (Linux 4.4.0-87-generic).
No matter the "layout.css.servo.enabled" pref is set to true or false, the checkbox is visible to me.

Hmm...wierd... :(

Comment 8

[Bobby Holley (:bholley)]

(In reply to tomaspartl from comment #5)
> I just checked and the checkbox is visible in Firefox 54.0 (64 bit) but not
> in the Nightly.
> Also, I discovered it stays invisible even if I turn of
> layout.css.servo.enabled , so I miscategorized it but it does seem like a
> Nightly bug.

Ok, removing from stylo tracking given the above. Thanks!

Comment 9

[tomaspartl]

Attachment: Screenshot: the check is there but invisible.

Comment 10

[Darkspirit]

Hm, you are testing with your main profile and have a fake user agent string.
Could you try the following steps?
1. Close Nightly. Create a fresh profile by running "path-to-your-nightly/firefox -P", click on Create Profile, then select it and click on Start Nightly.
2. open about:config and make sure that layout.css.servo.enabled is set to false (it should be if you are not participating an experiment)
3. open another tab: https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_checkbox_checked - Do you see the checkbox?
4. switch to your about:config tab, set layout.css.servo.enabled to true
5. reload your tab from (3) - Do you see the checkbox?
6. Close Nightly, run firefox -P again and select your main profile (probably "default") and start it to have it back.

a) You saw the checkbox every time: Then the cause might have been your custom config or an addon in your main profile.
b) You saw the checkbox in step 3 (stylo disabled), but not in step 5 (stylo enabled): Then it's a stylo bug.
c) You don't saw the checkbox in both cases: Some other component has a bug.

Comment 11

[Darkspirit]

(sorry) *didn't see

Comment 12

[Paul Rubin]

I'm seeing this too.  Someone on irc pointed to this pastebin which says something about using Gnome color choices is making the checkboxes display as white on white:

https://pastebin.com/JTJkBWDX

If it matters I'm using MATE rather than Gnome.  On my machine, ALL checkboxes don't show any visible checkmark, whether their actual state in the software is checked or unchecked.

Comment 13

[Paul Rubin]

Forgot to add, this is Firefox 55 on an old Fedora installation on a Thinkpad laptop.  The problem began today after I restarted Firefox.   The laptop must have auto-upgraded to 55 while the browser was left open.

Comment 14

[Paul Rubin]

Similar/dup: Bug 1386698

Comment 15

[Paul Rubin]

Still seeing this in 55.0.1 which downloaded today.  Check box is invisible with layout.css.servo.enabled both true and false, though I didn't try the other suggestions (create new profile etc) in Comment 10.

Comment 16

[Darkspirit]

(In reply to Paul Rubin from comment #12)
> https://pastebin.com/JTJkBWDX
"the color problem is likely related to your gtk3 theme"

> [...] which says something about using Gnome color choices is making the checkboxes display as white [...]
Ah, look, invisible checkboxes in some themes in the past:
 * https://askubuntu.com/a/893463
 * https://askubuntu.com/questions/86352/how-to-get-gtk3-checkboxes-in-certain-themes
or this one Firefox-related, too (from 2015): https://bbs.archlinux.org/viewtopic.php?id=206542
Also, there were bug 1091136 three years ago.

Could you try out some different themes? If that helps, we could definitely close this.
Or do you know an approximate regression window? (last) good version, (first) bad version

Comment 17

[Paul Rubin]

I'll see if I can try some different themes.  I first noticed this in 55.0 after restarting Firefox a few days ago.  Firefox had probably been running for a few days before that, and quietly took the auto-update during that time.  I didn't even realize I was using Gtk3, since I'm using Mate which is a fork of Gnome 2.  I remember someone in the pastebin saying it was nice that FF had started following the Gtk theme, so presumably there's an associated code change.

Comment 18

[Paul Rubin]

Changing themes did nothing for the check boxes and also didn't change the colors of the chrome (not sure if we are still supposed to call it that) around the browsed page.  Other windows on the screen did change color with the theme change.  In fact the text on popup menus (right click) also seems to have gone invisible with this black-on-white theme (BlackMATE).

Comment 19

[Paul Rubin]

My checkboxes are back even though the software (55.0.1) didn't change.  I think it may be because the browser didn't take the Gnome theme change til I closed and restarted it.  It hadn't occurred to me to do that at the time of the change, because all the other windows on my screen picked up the change right away.

I still wouldn't close this ticket, except to merge with dups.  There's been a definite annoying regression.  Telling people to change their theme is a hacky workaround, but not a substitute for having the check boxes display properly like they used to.

Comment 20

[Paul Rubin]

Re comment #14, meant bug #1388698.  Sorry.

Comment 21

[tomaspartl]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #10)
> Hm, you are testing with your main profile and have a fake user agent string.
> Could you try the following steps?
> 1. Close Nightly. Create a fresh profile by running
> "path-to-your-nightly/firefox -P", click on Create Profile, then select it
> and click on Start Nightly.
> 2. open about:config and make sure that layout.css.servo.enabled is set to
> false (it should be if you are not participating an experiment)
> 3. open another tab:
> https://www.w3schools.com/jsref/tryit.asp?filename=tryjsref_checkbox_checked
> - Do you see the checkbox?
> 4. switch to your about:config tab, set layout.css.servo.enabled to true
> 5. reload your tab from (3) - Do you see the checkbox?
> 6. Close Nightly, run firefox -P again and select your main profile
> (probably "default") and start it to have it back.
> 
> a) You saw the checkbox every time: Then the cause might have been your
> custom config or an addon in your main profile.
> b) You saw the checkbox in step 3 (stylo disabled), but not in step 5 (stylo
> enabled): Then it's a stylo bug.
> c) You don't saw the checkbox in both cases: Some other component has a bug.

I did it and I didn't see the checkbox with or without layout.css.servo.enabled.
I'm gonna try make a clean installation of the Xubuntu I'm using in VirtualBox and see if the problem shows there, too.
After reading what Paul Rubin says here, it seems to me it could be that my Xfce is messed up somehow.

Comment 22

[Milan Sreckovic [:milan] (needinfo for best results)]

I have the same problem with nightly on Windows 10.  Started with 20170814100258

Comment 23

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Milan Sreckovic [:milan] from comment #22)
> I have the same problem with nightly on Windows 10.  Started with
> 20170814100258

I'd happily change this to New from Unconfirmed, but can't get to the controls that do it :)

Comment 24

[Milan Sreckovic [:milan] (needinfo for best results)]

In my case, it was more than checkboxes - other controls were gone as well.  However, restarting Firefox seemed to have them show up again.

Comment 25

[tomaspartl]

I just tried Nightly on a fresh install of Xubuntu 16.04 in virtual box and the check boxes are visible, there's no problem at all. So, I guess my xubuntu installation is messed up - except that it's still kinda weird that the problem only shows in Nightly, not in FF. Anyway, if the bug is real, it will pop up to bite us all in the butt later. For now, I'll just try to figure out how to fix my xubu.

Comment 26

[Andrew Overholt [:overholt]]

Attachment: about:support

I'm seeing this right now in Nightly on Windows 10 with Stylo enabled (I'm attaching my about:support output so you can see all my printers ;). I have a few tabs with bugs open in different content processes and <input type="checkbox"> are missing in all of them.

Browser console output:

Attempt to set a forbidden header was denied: Connection  2030600546-bc_manager_core.js:75:107
Attempt to set a forbidden header was denied: Connection  2030600546-bc_manager_core.js:75:107
Attempt to set a forbidden header was denied: Connection rs=AHGWq9BPSrlhQZkCyNESBXUEVvxIwgyDOw:208:85
Attempt to set a forbidden header was denied: Connection  2030600546-bc_manager_core.js:75:107
Attempt to set a forbidden header was denied: Connection  2030600546-bc_manager_core.js:75:107
Attempt to set a forbidden header was denied: Connection  3808351375-lcs_client_bin.js:100:385
Attempt to set a forbidden header was denied: Connection  2030600546-bc_manager_core.js:75:107
Content Security Policy: Ignoring ‘x-frame-options’ because of ‘frame-ancestors’ directive. (unknown)
Invalid chrome URI: /Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user’s experience. For more help http://xhr.spec.whatwg.org/  require-kernel.js:1:2461
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user’s experience. For more help http://xhr.spec.whatwg.org/  quantumdom:9:2461
Use of getPreventDefault() is deprecated.  Use defaultPrevented instead.  quantumdom%20line%209%20%3E%20Function:12:8760
Use of getPreventDefault() is deprecated.  Use defaultPrevented instead.  ace2_common.js:10:8760
Use of nsIFile in content process is deprecated.  NetUtil.jsm:307:12
TypeError: this.win is null auto-refresh.js:202:9
Attempt to set a forbidden header was denied: Connection  2030600546-bc_manager_core.js:75:107
TypeError: this.win is null auto-refresh.js:202:9
Blocked loading mixed active content “http://www.torontopubliclibrary.ca/js_topnav_preload.js”[Learn More] login
Blocked loading mixed active content “http://www.torontopubliclibrary.ca/js_global.js”[Learn More] login
Loading failed for the <script> with source “http://www.torontopubliclibrary.ca/js_topnav_preload.js”.  login:5
Loading failed for the <script> with source “http://www.torontopubliclibrary.ca/js_global.js”.  login:6
Invalid chrome URI: /ReferenceError: preloadTopNav is not defined  login:1:12
TypeError: this.win is null auto-refresh.js:202:9
Loading failed for the <script> with source “http://www.torontopubliclibrary.ca/js_topnav_preload.js”.  login:5
Loading failed for the <script> with source “http://www.torontopubliclibrary.ca/js_global.js”.  login:6
Invalid chrome URI: /ReferenceError: preloadTopNav is not defined  login:1:12
TypeError: this.win is null auto-refresh.js:202:9
Invalid chrome URI: /TypeError: this.win is null  auto-refresh.js:202:9
Invalid chrome URI: /TypeError: this.win is null auto-refresh.js:202:9
Attempt to set a forbidden header was denied: Connection  2030600546-bc_manager_core.js:75:107
TypeError: this.win is null  auto-refresh.js:202:9
TypeError: this.win is null auto-refresh.js:202:9
Attempt to set a forbidden header was denied: Connection  2030600546-bc_manager_core.js:75:107
TypeError: this.win is null auto-refresh.js:202:9
TypeError: this.win is null auto-refresh.js:202:9
Attempt to set a forbidden header was denied: Connection  2030600546-bc_manager_core.js:75:107
TypeError: this.win is null auto-refresh.js:202:9
TypeError: this.win is null auto-refresh.js:202:9
TypeError: this.win is null auto-refresh.js:202:9
TypeError: this.win is null auto-refresh.js:202:9
Attempt to set a forbidden header was denied: Connection  2030600546-bc_manager_core.js:75:107
TypeError: this.win is null  auto-refresh.js:202:9
TypeError: this.win is null auto-refresh.js:202:9
Attempt to set a forbidden header was denied: Connection  2030600546-bc_manager_core.js:75:107
TypeError: this.win is null auto-refresh.js:202:9
TypeError: this.win is null auto-refresh.js:202:9
TypeError: this.win is null auto-refresh.js:202:9
Attempt to set a forbidden header was denied: Connection  rs=AHGWq9BPSrlhQZkCyNESBXUEVvxIwgyDOw:208:85
TypeError: this.win is null auto-refresh.js:202:9
TypeError: this.win is null auto-refresh.js:202:9
TypeError: this.win is null auto-refresh.js:202:9
Attempt to set a forbidden header was denied: Connection  2030600546-bc_manager_core.js:75:107
TypeError: this.win is null auto-refresh.js:202:9
Attempt to set a forbidden header was denied: Connection  2030600546-bc_manager_core.js:75:107
TypeError: this.win is null auto-refresh.js:202:9
TypeError: this.win is null auto-refresh.js:202:9
Attempt to set a forbidden header was denied: Connection  3808351375-lcs_client_bin.js:100:385
TypeError: this.win is null  auto-refresh.js:202:9

Comment 27

[Andrew Overholt [:overholt]]

Using my fancy Surface Book I detached the screen/tablet thing on to get a different GPU (the Intel one vs. the discrete Nvidia one) and nothing changed.

Refreshing the page (including with holding Ctrl) doesn't have any effect.

Comment 28

[Milan Sreckovic [:milan] (needinfo for best results)]

I'm going to move this to layout, let style folk take a crack at it.

Comment 29

[Bobby Holley (:bholley)]

(In reply to Milan Sreckovic [:milan] from comment #28)
> I'm going to move this to layout, let style folk take a crack at it.

From the comments in this bug, it seems like this is orthogonal to stylo, right? If so, I don't really have cycles to look at it in the 57 timeframe.

Comment 30

[Andrew Overholt [:overholt]]

(In reply to Andrew Overholt [:overholt] from comment #26)
> <input type="checkbox"> are missing in all of them.

<input> are OK but <input type="submit"> are not.

Comment 31

[Andrew Overholt [:overholt]]

I'm experiencing this again today in one of my content processes. It turns out that scrollbars are also solid black in it and other content processes; coincidence?

Who knows what to do to get more investigation here? Jet, do you?

Comment 32

[Andrew Overholt [:overholt]]

I also see some Google Calendar confirmation boxes not having their backgrounds/outlines painted in *other* content processes.

Comment 33

[Andrew Overholt [:overholt]]

[Tracking Requested - why for this release]:

Comment 34

[Jet Villegas (inactive)]

(In reply to Milan Sreckovic [:milan] from comment #22)
> I have the same problem with nightly on Windows 10.  Started with
> 20170814100258

That build was built from this revision:
https://hg.mozilla.org/mozilla-central/shortlog/df9beb781895

I think that the Linux theme-related reports are different from the Windows reports. Can we get some screenshots from the Windows reports?

Comment 35

[Milan Sreckovic [:milan] (needinfo for best results)]

If it happens again for me, sure.  I haven't seen it since the original report.

Comment 36

[Andrew Overholt [:overholt]]

Attachment: invisible bugzilla checkbox

(In reply to Jet Villegas (:jet) from comment #34)
> Can we get some screenshots from the Windows reports?

Here's one I mocked up but it's what I see when this happens. The checkbox is in the DOM but not drawn (just like the attachment from comment 9 shows).

Comment 37

[Milan Sreckovic [:milan] (needinfo for best results)]

Yes, that looks like what I was seeing.

Comment 38

[Milan Sreckovic [:milan] (needinfo for best results)]

I seem to have an STR for this.  I'll look for a regression range.

Comment 40

[Julien Cristau [:jcristau]]

Moving tracking flags to bug 1396984

Comment 41

[tomaspartl]

Okay, it's fixed now. I was upgraded to nightly 58.0a1 (2017-11-03) just a few minutes ago and the checkboxes are visible again.