Closed
Bug 1386664
Opened 7 years ago
Closed 7 years ago
Add "Knuckles" string id for SteamVR Knuckles controllers
Categories
(Core :: WebVR, defect)
Core
WebVR
Tracking
()
RESOLVED
FIXED
mozilla56
People
(Reporter: daoshengmu, Assigned: daoshengmu)
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
kip
:
review+
gchang
:
approval-mozilla-beta+
|
Details |
We need to give an identifier for SteamVR Knuckles. I think "OpenVR Knuckles" would be the best.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → dmu
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
After finishing review, We should uplift it because Bug 1382123 has landed in FF 56.
Target Milestone: --- → mozilla56
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8893689 [details] Bug 1386664 - Add Knuckles string id for SteamVR Knuckles controllers; https://reviewboard.mozilla.org/r/164808/#review171378 This LGTM, Thanks!
Attachment #8893689 -
Flags: review?(kgilbert) → review+
Pushed by dmu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/62ab0af2c3ef Add Knuckles string id for SteamVR Knuckles controllers; r=kip
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/62ab0af2c3ef
Assignee | ||
Comment 6•7 years ago
|
||
Comment on attachment 8893689 [details] Bug 1386664 - Add Knuckles string id for SteamVR Knuckles controllers; Approval Request Comment [Feature/Bug causing the regression]: Add a string id for recognizing controllers. [User impact if declined]: Can't have a way to identify the button/axis order. [Is this code covered by automated tests?]: nope. It needs a physical device, so I test it manually. [Has the fix been verified in Nightly?]: yes!. [Needs manual test from QE? If yes, steps to reproduce]: nope. [List of other uplifts needed for the feature/fix]: nope. [Is the change risky?]: nope. [Why is the change risky/not risky?]: Just add a string id for recognizing. [String changes made/needed]: nope.
Attachment #8893689 -
Flags: approval-mozilla-beta?
Updated•7 years ago
|
status-firefox56:
--- → affected
Comment 7•7 years ago
|
||
Comment on attachment 8893689 [details] Bug 1386664 - Add Knuckles string id for SteamVR Knuckles controllers; Fix an issue related to button/axis identification. Beta56+.
Attachment #8893689 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 8•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/fbbcff950d93
You need to log in
before you can comment on or make changes to this bug.
Description
•