Inline StackDefs and StackUses

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

(Blocks 1 bug)

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
Posted patch PatchSplinter Review
Both of these functions are called hundreds of thousands of times on Speedometer. The functions are so simple that they really should be inlined.

I also removed the unused JSScript* arguments.
Attachment #8892942 - Flags: review?(tcampbell)
Comment on attachment 8892942 [details] [diff] [review]
Patch

Review of attachment 8892942 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds like a good idea.
Attachment #8892942 - Flags: review?(tcampbell) → review+

Comment 2

2 years ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4eefdf977b3f
Clean up and inline StackDefs and StackUses functions. r=tcampbell
(Assignee)

Comment 3

2 years ago
It just occurred to me I should have changed GetUseCount and GetDefCount to take the pc instead of script + offset, to avoid unnecessary pc <-> offset conversions.
Attachment #8893324 - Flags: review?(tcampbell)
Comment on attachment 8893324 [details] [diff] [review]
Part 2 - Change GetUseCount and GetDefCount to take pc instead of script + offset

Review of attachment 8893324 [details] [diff] [review]:
-----------------------------------------------------------------

Good find.
Attachment #8893324 - Flags: review?(tcampbell) → review+

Comment 5

2 years ago
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/168a856b9f90
part 2 - Change GetUseCount and GetDefCount to take pc instead of script + offset. r=tcampbell

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4eefdf977b3f
https://hg.mozilla.org/mozilla-central/rev/168a856b9f90
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57

Comment 7

2 years ago
https://hg.mozilla.org/projects/date/rev/4eefdf977b3f0bb5497f2be999d75eccd34ea502
Bug 1386685 - Clean up and inline StackDefs and StackUses functions. r=tcampbell

https://hg.mozilla.org/projects/date/rev/168a856b9f900c5269045766e8b632d795d82be6
Bug 1386685 part 2 - Change GetUseCount and GetDefCount to take pc instead of script + offset. r=tcampbell
You need to log in before you can comment on or make changes to this bug.