1386719 - If poll returns PR_POLL_EXCEPT during ConnectEx on windows check OVERLAPPED as well

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Dragana Damjanovic [:dragana]]

This is nspr fix for bug 1385116

Comment 1

[Dragana Damjanovic [:dragana]]

Also I found out that ConnectEx returns ERROR_CONNECTION_REFUSED from call WSAGetLastError().
ERROR_CONNECTION_REFUSED is not a WSA error and it does not have the same value as WSAECONNREFUSED.

_PR_MD_MAP_CONNECT_ERROR does not recognize ERROR_CONNECTION_REFUSED. I am not sure if this is happening with other error and it is hard to trigger, to investigate.

Comment 2

[Dragana Damjanovic [:dragana]]

Attachment: bug_1386719_v1.patch

Comment 3

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ca32395f5048d1e603090423879e44c3365976a

xcpshell tests on win10 where failing before this patch.

Comment 4

[Dragana Damjanovic [:dragana]]

this was not happening on my VM and one other computer. and it is not happening for a lot pf people. At least we have only one bug: bug 1385116 and out try servers.

Comment 5

[Dragana Damjanovic [:dragana]]

Attachment: bug_1386719_v1.patch

I needed to extend the error list.
in bug 1385116, the reporter is seeing error ERROR_INVALID_NETNAME (1214).

I have added some other error. If you think they are not correct please let me know, maybe I made a necko patch that retries connection without TFO if PR_ContinueConnect error is PR_UNKNOWN_ERROR (i.e. if we cannot decode non WSA error)

Comment 6

[Kai Engert (:KaiE:)]

Comment on attachment 8895264 [details] [diff] [review]
bug_1386719_v1.patch

I don't object this windows-specific change, Honza's review is enough.

Comment 7

[Kai Engert (:KaiE:)]

Build breakage

c:/Users/task_1503674852/nspr/Debug/pr/src/io/../../../../pr/src/io/prsocket.c(307): error C2039: 'overlappedActive': is not a member of 'PRFilePrivate'
c:\Users\task_1503674852\nspr\pr\include\private\primpl.h(1732): note: see declaration of 'PRFilePrivate'
c:/Users/task_1503674852/nspr/Debug/pr/src/io/../../../../pr/src/io/prsocket.c(309): warning C4022: 'GetOverlappedResult': pointer mismatch for actual parameter 1
c:/Users/task_1503674852/nspr/Debug/pr/src/io/../../../../pr/src/io/prsocket.c(309): error C2039: 'ol': is not a member of 'PRFilePrivate'
c:\Users\task_1503674852\nspr\pr\include\private\primpl.h(1732): note: see declaration of 'PRFilePrivate'
c:/Users/task_1503674852/nspr/Debug/pr/src/io/../../../../pr/src/io/prsocket.c(309): warning C4133: 'function': incompatible types - from 'PRInt32 *' to 'LPOVERLAPPED'
c:/Users/task_1503674852/nspr/Debug/pr/src/io/../../../../pr/src/io/prsocket.c(309): error C2198: 'GetOverlappedResult': too few arguments for call
c:/Users/task_1503674852/nspr/Debug/pr/src/io/../../../../pr/src/io/prsocket.c(315): error C2039: 'overlappedActive': is not a member of 'PRFilePrivate'
c:\Users\task_1503674852\nspr\pr\include\private\primpl.h(1732): note: see declaration of 'PRFilePrivate'
make[3]: *** [prsocket.obj] Error 2
make[3]: Leaving directory `/c/Users/task_1503674852/nspr/Debug/pr/src/io'
make[2]: *** [export] Error 2
make[2]: Leaving directory `/c/Users/task_1503674852/nspr/Debug/pr/src'
make[1]: *** [export] Error 2
make[1]: Leaving directory `/c/Users/task_1503674852/nspr/Debug/pr'
make: *** [export] Error 2
make: Leaving directory `/c/Users/task_1503674852/nspr/Debug'

Comment 8

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/projects/nspr/rev/aa88ba8082ec

Comment 9

[Dragana Damjanovic [:dragana]]

Attachment: bug_1386719_v1.patch

Forgot to add '#if defined(_WIN64)'

Comment 10

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=de11675235d15c5fd09290ebb3ea6a65168941cd

Comment 11

[Kai Engert (:KaiE:)]

checked in bustage fix
https://hg.mozilla.org/projects/nspr/rev/c60f6aa3770a