Closed Bug 1386724 Opened 2 years ago Closed 2 years ago

devtools/client/framework/test/browser_dynamic_tool_enabling.js fails when running locally

Categories

(DevTools :: Framework, enhancement)

enhancement
Not set

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

If no other tests run before browser_dynamic_tool_enabling.js then it fails. We had some bad luck with https://bugzilla.mozilla.org/show_bug.cgi?id=1380709#c24, in which a patch forced this test to be the first in a chunk and we hit this issue.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Comment on attachment 8892982 [details]
Bug 1386724 - Force devtools-browser to be loaded in shared-head.js;

https://reviewboard.mozilla.org/r/163986/#review169292

LGTM, thanks!
Attachment #8892982 - Flags: review?(jdescottes) → review+
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/26ce8836a4c8
Force devtools-browser to be loaded in shared-head.js;r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/26ce8836a4c8
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.