Tabs have white text on light grey background on 10.9

VERIFIED FIXED in Firefox 57

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
11 months ago
10 months ago

People

(Reporter: jrmuizel, Assigned: dao)

Tracking

({regression})

unspecified
Firefox 57
regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 unaffected, firefox57 verified)

Details

(Whiteboard: [photon-visual][p1])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

This regressed yesterday.
Keywords: regression, regressionwindow-wanted
I think we need a fallback background-color for macOS versions that don't have vibrancy (10.9).
Blocks: 1377284
Keywords: regressionwindow-wanted

Updated

11 months ago
Whiteboard: [photon-visual] [triage]

Updated

11 months ago
Flags: qe-verify?
Priority: -- → P2
Whiteboard: [photon-visual] [triage] → [photon-visual]
status-firefox55: --- → unaffected
status-firefox56: --- → unaffected
status-firefox57: --- → affected
status-firefox-esr52: --- → unaffected
(Assignee)

Updated

11 months ago
Whiteboard: [photon-visual] → [photon-visual][p1]
(Assignee)

Updated

11 months ago
Duplicate of this bug: 1388109

Comment 3

11 months ago
BTW, how are they supposed to appear?  Dark text on light grey background, or white text on dark background?
White text on dark background.

Comment 5

11 months ago
(In reply to Markus Stange [:mstange] from comment #4)
> White text on dark background.

:-(  Dark text on the grey background would be more conducive to the look of OS X.

Oh well...
Comment hidden (mozreview-request)
(Assignee)

Updated

11 months ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Flags: qe-verify? → qe-verify+
Priority: P2 → P1

Updated

11 months ago
Iteration: --- → 57.1 - Aug 15
QA Contact: brindusa.tot

Comment 7

11 months ago
mozreview-review
Comment on attachment 8895839 [details]
Bug 1386730 - Set fallback titlebar background for when -moz-mac-vibrancy-dark isn't available (e.g. OS X 10.9).

https://reviewboard.mozilla.org/r/167134/#review172296
Attachment #8895839 - Flags: review?(nhnt11) → review+

Comment 8

11 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4fa607fc5f7e
Set fallback titlebar background for when -moz-mac-vibrancy-dark isn't available (e.g. OS X 10.9). r=nhnt11

Comment 9

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4fa607fc5f7e
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57

Updated

10 months ago
QA Contact: brindusa.tot → ovidiu.boca

Comment 10

10 months ago
Can you please tell me what are the expected results here? If the browser has the "Light" theme then the tab text should be white or "White text on dark background." like in comment 4? Thanks 

From what I see now on Mac OS if the theme is dark the text from the tab is white.
Flags: needinfo?(dao+bmo)
(Assignee)

Comment 11

10 months ago
(In reply to ovidiu boca[:Ovidiu] from comment #10)
> Can you please tell me what are the expected results here? If the browser
> has the "Light" theme then the tab text should be white or "White text on
> dark background." like in comment 4? Thanks 

This bug is about the default theme, not the Light or Dark variants.

> From what I see now on Mac OS if the theme is dark the text from the tab is
> white.

Right, a dark background should get bright text so that the text is legible.
Flags: needinfo?(dao+bmo)

Comment 12

10 months ago
I verified this on Mac OS X 10.10 and Mac OS X 10.12 with Nightly 57.0a1(2017-08-18) and I can confirm the fix.
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.