bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Generate and send scrollthumb animation id to compositor

RESOLVED FIXED in Firefox 57

Status

()

Core
Graphics: WebRender
P3
normal
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: kats, Assigned: kats)

Tracking

Other Branch
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [gfx-noted])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

In the layers WR code, we made sure that all scroll thumb layers had an animation id [1] so that we could have APZ animate their transform during async scrolling. We need to do the same for layers-free mode.

http://searchfox.org/mozilla-central/rev/bbc1c59e460a27b20929b56489e2e55438de81fa/gfx/layers/wr/WebRenderContainerLayer.cpp#80-91
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=39d52629b6523fb6fae2014fc1e765cb3f394565

I'll need to rebase part 1 on top of bug 1386553 before landing but that should be pretty simple.
Depends on: 1384616

Comment 4

a year ago
mozreview-review
Comment on attachment 8893013 [details]
Bug 1386747 - Ensure that scroll thumb display items generate animation IDs.

https://reviewboard.mozilla.org/r/164022/#review169592
Attachment #8893013 - Flags: review?(ethlin) → review+

Comment 5

a year ago
mozreview-review
Comment on attachment 8893014 [details]
Bug 1386747 - Put the scroll thumb's animation id in the scroll data for APZ.

https://reviewboard.mozilla.org/r/164024/#review169590
Attachment #8893014 - Flags: review?(ethlin) → review+

Comment 6

a year ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1eb81f0f0e50
Ensure that scroll thumb display items generate animation IDs. r=ethlin
https://hg.mozilla.org/integration/mozilla-inbound/rev/bebab4283bed
Put the scroll thumb's animation id in the scroll data for APZ. r=ethlin

Comment 7

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1eb81f0f0e50
https://hg.mozilla.org/mozilla-central/rev/bebab4283bed
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
https://hg.mozilla.org/projects/date/rev/1eb81f0f0e50850fa1c43cbbd37791e5d3784677
Bug 1386747 - Ensure that scroll thumb display items generate animation IDs. r=ethlin

https://hg.mozilla.org/projects/date/rev/bebab4283bed00d13ffa71729c0f60eb60c20ada
Bug 1386747 - Put the scroll thumb's animation id in the scroll data for APZ. r=ethlin
You need to log in before you can comment on or make changes to this bug.