Make a nsACString overload of nsAccessibilityService::GetStringEventType

RESOLVED FIXED in Firefox 57

Status

()

Core
Disability Access APIs
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: aklotz, Assigned: aklotz)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
Profiler APIs accept const char*.

When making markers, I don't think it makes any sense to waste time converting UTF8 to UTF16 only to convert back again.
(Assignee)

Updated

9 months ago
Blocks: 1386798
(Assignee)

Comment 1

9 months ago
Created attachment 8893103 [details] [diff] [review]
Patch
Attachment #8893103 - Flags: review?(surkov.alexander)

Comment 2

9 months ago
Comment on attachment 8893103 [details] [diff] [review]
Patch

Review of attachment 8893103 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/base/nsAccessibilityService.cpp
@@ +933,5 @@
> +nsAccessibilityService::GetStringEventType(uint32_t aEventType,
> +                                           nsACString& aString)
> +{
> +  NS_ASSERTION(nsIAccessibleEvent::EVENT_LAST_ENTRY == ArrayLength(kEventTypeNames),
> +               "nsIAccessibleEvent constants are out of sync to kEventTypeNames");

MOZ_ASSERT please
Attachment #8893103 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 3

9 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/99837e8b5a692ac96257d2bae03a3867c4c80e7e
Bug 1386836: Add a nsACString overload to nsAccessibilityService::GetStringEventType; r=surkov

Comment 4

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/99837e8b5a69
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.