1386854 - Use diagnostic assertions for SchedulerGroup validation

Status: RESOLVED WONTFIX

(Core :: DOM: Content Processes, enhancement, P3)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Currently we use a DEBUG-mode assert here:
http://searchfox.org/mozilla-central/rev/f0e4ae5f8c40ba742214e89aba3f554da0b89a33/xpcom/threads/SchedulerGroup.h#81

The correctness of Quantum DOM scheduling relies on labeling being correct, so it would be good to start using real assertions here to catch problems in the wild. We couldn't do this with legacy add-ons around since they could violate the assertions. Now we can do it.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8893130 [details] [diff] [review]
patch

Scary :) (but needed.)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:billm, could you have a look please?

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:billm, could you have a look please?

Comment 5

[Andrew McCreight [:mccr8]]

I'm just going to WONTFIX this to hopefully stop the bot needinfos for now.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Clearing the needinfo since most of the qdom code has been removed.