Closed
Bug 1386870
Opened 7 years ago
Closed 7 years ago
Remove unnecessary RootedScripts on Interpreter call path
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: sstangl, Assigned: sstangl)
Details
Attachments
(1 file)
|
3.07 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
RunState maintains an internal RootedScript, and elsewhere the JSScript is passed as HandleScript. So it is not necessary to construct another RootedScript. These functions execute every time the interpreter calls a function, so this should decreasing rooting traffic in a meaningful way.
Attachment #8893131 -
Flags: review?(sphink)
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → sstangl
|
||
Updated•7 years ago
|
Attachment #8893131 -
Flags: review?(sphink) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f5f9c8c65fe9 Remove unnecessary RootedScripts on Interpreter call path. r=sfink
Keywords: checkin-needed
|
||
Comment 2•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f5f9c8c65fe9
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
|
||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/projects/date/rev/f5f9c8c65fe9b14c8da589adf05d84aad221d241 Bug 1386870 - Remove unnecessary RootedScripts on Interpreter call path. r=sfink
You need to log in
before you can comment on or make changes to this bug.
Description
•