1386951 - Have ChannelMediaDecoder implement CreateStateMachine()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

The implementation will be shared by most of the sub-classes except OggDecoder which needs to call demuxer->SetChainingEvents().

http://searchfox.org/mozilla-central/rev/f0e4ae5f8c40ba742214e89aba3f554da0b89a33/dom/media/ogg/OggDecoder.cpp#25

This help reduce code changes whenever we add a field to MediaFormatReaderInit.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1386951 - have ChannelMediaDecoder implement CreateStateMachine() and fix includes.

The implementation will be shared by most of the sub-classes except OggDecoder
which needs to call demuxer->SetChainingEvents().

http://searchfox.org/mozilla-central/rev/f0e4ae5f8c40ba742214e89aba3f554da0b89a33/dom/media/ogg/OggDecoder.cpp#25

This help reduce code changes whenever we add a field to MediaFormatReaderInit.

Review commit: https://reviewboard.mozilla.org/r/164354/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164354/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8893294 [details]
Bug 1386951 - have ChannelMediaDecoder implement CreateStateMachine() and fix includes.

https://reviewboard.mozilla.org/r/164354/#review169702

::: commit-message-0c7e7:8
(Diff revision 1)
> +The implementation will be shared by most of the sub-classes except OggDecoder
> +which needs to call demuxer->SetChainingEvents().
> +
> +http://searchfox.org/mozilla-central/rev/f0e4ae5f8c40ba742214e89aba3f554da0b89a33/dom/media/ogg/OggDecoder.cpp#25
> +
> +This help reduce code changes whenever we add a field to MediaFormatReaderInit.

this help reducing

::: dom/media/ChannelMediaDecoder.cpp:160
(Diff revision 1)
>    mResourceCallback->Connect(this);
>  }
>  
> +MediaDecoderStateMachine* ChannelMediaDecoder::CreateStateMachine()
> +{
> +  MediaFormatReaderInit init;

Please add MOZ_ASSERT(NS_IsMainThread());

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8893294 [details]
Bug 1386951 - have ChannelMediaDecoder implement CreateStateMachine() and fix includes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164354/diff/1-2/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be090e170cc6
have ChannelMediaDecoder implement CreateStateMachine() and fix includes. r=jya

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/be090e170cc6