1386963 - stylo: make 'image-orientation' and 'paint-order' animatable

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Daisuke Akatsuka (:daisuke)]

Both 'image-orientation' and 'paint-order' should animate discretely.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1386963 - Part 1: make paint-order animatable.

Review commit: https://reviewboard.mozilla.org/r/164318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164318/

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1386963 - Part 2: make image-orientation animatable.

Review commit: https://reviewboard.mozilla.org/r/164320/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164320/

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1386963 - Part 3: remove test fail annotations from meta in wpt.

Since we make 'image-orientation' and 'paint-order' properties animatable,
remove test fail annotations from meta in wpt.

Review commit: https://reviewboard.mozilla.org/r/164322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164322/

Comment 4

[Daisuke Akatsuka (:daisuke)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7234dc364ee804529baf6013807eed128acf5491

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8893274 [details]
Bug 1386963 - Part 3: remove test fail annotations from meta in wpt.

https://reviewboard.mozilla.org/r/164322/#review169640

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8893272 [details]
Bug 1386963 - Part 1: make paint-order animatable.

https://reviewboard.mozilla.org/r/164318/#review169648

::: servo/components/style/properties/gecko.mako.rs:5087
(Diff revision 1)
> +        use self::longhands::paint_order::SpecifiedValue;
> +
> +        if self.gecko.mPaintOrder == structs::NS_STYLE_PAINT_ORDER_NORMAL as u8 {
> +            return SpecifiedValue(NORMAL);
> +        }

Use computed_value::T instead of SpecifiedValue.

::: servo/components/style/properties/gecko.mako.rs:5093
(Diff revision 1)
> +
> +        if self.gecko.mPaintOrder == structs::NS_STYLE_PAINT_ORDER_NORMAL as u8 {
> +            return SpecifiedValue(NORMAL);
> +        }
> +
> +        let mask = (1 << structs::NS_STYLE_PAINT_ORDER_BITWIDTH) - 1;

Can we define this as const u8?

::: servo/components/style/properties/gecko.mako.rs:5105
(Diff revision 1)
> +                    structs::NS_STYLE_PAINT_ORDER_MARKERS => MARKERS,
> +                    _ => unreachable!(),
> +                };
> +            order |= value << (pos * SHIFT);
> +        };
> +        SpecifiedValue(order)

Use computed_value:T.

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8893273 [details]
Bug 1386963 - Part 2: make image-orientation animatable.

https://reviewboard.mozilla.org/r/164320/#review169664

Comment 8

[Daisuke Akatsuka (:daisuke)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #6)
> Comment on attachment 8893272 [details]
> Bug 1386963 - Part 1: make paint-order animatable.
> 
> https://reviewboard.mozilla.org/r/164318/#review169648
> 
> ::: servo/components/style/properties/gecko.mako.rs:5087
> (Diff revision 1)
> > +        use self::longhands::paint_order::SpecifiedValue;
> > +
> > +        if self.gecko.mPaintOrder == structs::NS_STYLE_PAINT_ORDER_NORMAL as u8 {
> > +            return SpecifiedValue(NORMAL);
> > +        }
> 
> Use computed_value::T instead of SpecifiedValue.
> 
> ::: servo/components/style/properties/gecko.mako.rs:5093
> (Diff revision 1)
> > +
> > +        if self.gecko.mPaintOrder == structs::NS_STYLE_PAINT_ORDER_NORMAL as u8 {
> > +            return SpecifiedValue(NORMAL);
> > +        }
> > +
> > +        let mask = (1 << structs::NS_STYLE_PAINT_ORDER_BITWIDTH) - 1;
> 
> Can we define this as const u8?
> 
> ::: servo/components/style/properties/gecko.mako.rs:5105
> (Diff revision 1)
> > +                    structs::NS_STYLE_PAINT_ORDER_MARKERS => MARKERS,
> > +                    _ => unreachable!(),
> > +                };
> > +            order |= value << (pos * SHIFT);
> > +        };
> > +        SpecifiedValue(order)
> 
> Use computed_value:T.

Thanks, Hiro!
Will fix and PR them.

Comment 9

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8893272 [details]
Bug 1386963 - Part 1: make paint-order animatable.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164318/diff/1-2/

Comment 10

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8893273 [details]
Bug 1386963 - Part 2: make image-orientation animatable.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164320/diff/1-2/

Comment 11

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8893274 [details]
Bug 1386963 - Part 3: remove test fail annotations from meta in wpt.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164322/diff/1-2/

Comment 12

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 8893274 [details]
Bug 1386963 - Part 3: remove test fail annotations from meta in wpt.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164322/diff/2-3/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b10ab5ac752e
Part 3: remove test fail annotations from meta in wpt. r=hiro

Comment 14

[Daisuke Akatsuka (:daisuke)]

Attachment: Servo PR 17964

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b10ab5ac752e