Let nsIRadioGroupContainer::Add/RemoveToRadioGroup() take HTMLInputElement* as argument

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
a month ago

People

(Reporter: jessica, Assigned: jessica)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Now these two functions take nsIFormControl* as argument, but actually we only pass HTMLInputElements here, so we can change it to HTMLInputElement* to avoid  redundant casting.
Posted patch patch, v1.Splinter Review
Attachment #8893285 - Flags: review?(bzbarsky)
Comment on attachment 8893285 [details] [diff] [review]
patch, v1.

r=me.  Thank you for doing this!
Attachment #8893285 - Flags: review?(bzbarsky) → review+

Comment 4

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c287f05bc63
Change nsIRadioGroupContainer::Add/RemoveToRadioGroup() to take HTMLInputElement* as argument. r=bz
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3c287f05bc63
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.