Let nsIRadioGroupContainer::Add/RemoveToRadioGroup() take HTMLInputElement* as argument

RESOLVED FIXED in Firefox 57

Status

()

Core
DOM
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: jessica, Assigned: jessica)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
Now these two functions take nsIFormControl* as argument, but actually we only pass HTMLInputElements here, so we can change it to HTMLInputElement* to avoid  redundant casting.
(Assignee)

Comment 1

5 months ago
Created attachment 8893285 [details] [diff] [review]
patch, v1.
Attachment #8893285 - Flags: review?(bzbarsky)
Comment on attachment 8893285 [details] [diff] [review]
patch, v1.

r=me.  Thank you for doing this!
Attachment #8893285 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

5 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=540cd80b40fce2ad68ce4afa457526902878c7a2&group_state=expanded
Keywords: checkin-needed

Comment 4

5 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c287f05bc63
Change nsIRadioGroupContainer::Add/RemoveToRadioGroup() to take HTMLInputElement* as argument. r=bz
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3c287f05bc63
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.