1387023 - Test browser_989751_subviewbutton_class.js fails in isolation because devtools are not initialized

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[Julian Descottes [:jdescottes]]

After Bug 1359855 devtools are only initialized when the user first interacts with a valid entry point such as :
- a devtools keyboard shortcut
- a devtools menu entry
- a devtools command line option

The devtools initialization is responsible of filling the menuWebDeveloperPopup based on the currently enabled tools.

In the test browser/components/customizableui/test/browser_989751_subviewbutton_class.js we try to add a class to an item in this popup before displaying the developer menu (which contains items copied from menuWebDeveloperPopup).

If this test is run in isolation (or is the first to run in its chunk) it will fail. 

Ideally, as devtools should move to an addon, we should make the test rely on another set of buttons/popups. I tried to migrate it to use the history button / panels, but it doesn't seem to be using the same mechanism as the devtools one. 

For the time being, in order to avoid inconsistent failures, we should at least initialize devtools at the beginning of the test by requiring devtools-browser.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1387023 - initialize devtools before asserting menu items in browser_989751_subviewbutton_class.js;

Review commit: https://reviewboard.mozilla.org/r/164446/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164446/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8893356 [details]
Bug 1387023 - initialize devtools before asserting menu items in browser_989751_subviewbutton_class.js;

https://reviewboard.mozilla.org/r/164446/#review169728

Nice, thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f66e161dd72f
initialize devtools before asserting menu items in browser_989751_subviewbutton_class.js;r=Gijs

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f66e161dd72f