1387046 - CompositorOptions operator== doesn't check advanced layers flag

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Spotted this while reading code

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1387046 - Add missing field to operator== in CompositorOptions.

Review commit: https://reviewboard.mozilla.org/r/164498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164498/

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8893383 [details]
Bug 1387046 - Add missing field to operator== in CompositorOptions.

https://reviewboard.mozilla.org/r/164498/#review169868

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3758e58e7846
Add missing field to operator== in CompositorOptions. r=dvander

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3758e58e7846

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8893383 [details]
Bug 1387046 - Add missing field to operator== in CompositorOptions.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1365879
[User impact if declined]: unsure, probably nothing. it might result in subtle errors when advanced layers is toggled because the state might not get propagated properly.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: there's no STR or visible issues, so nothing to verify really
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: trivial correction
[String changes made/needed]: none

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8893383 [details]
Bug 1387046 - Add missing field to operator== in CompositorOptions.

A trivial fix. Should be low risk. Beta56+. Should be in 56 beta 2.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ef3ed480fc3f