Having these functions declared in the class definition and therefore inlined means that every call site is bloated by having to store the argument so its address can be taken and load the sizeof() constant. There's no good reason that we should be doing this; the Read* counterparts are also out-of-lined, which hasn't seemed to cause any problems. Moving these out-of-line saves about 200K (!) of space on x86-64 Linux.
Created attachment 8893472 [details] [diff] [review] out-of-line type-specific Pickle::Write* methods
Attachment #8893472 - Flags: review?(wmccloskey)
Attachment #8893472 - Flags: review?(wmccloskey) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/c541ddcbcac5 out-of-line type-specific Pickle::Write* methods; r=billm
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.