out-of-line type-specific Pickle::Write* methods

RESOLVED FIXED in Firefox 57

Status

()

Core
IPC
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
Having these functions declared in the class definition and therefore
inlined means that every call site is bloated by having to store the
argument so its address can be taken and load the sizeof() constant.
There's no good reason that we should be doing this; the Read*
counterparts are also out-of-lined, which hasn't seemed to cause any
problems.  Moving these out-of-line saves about 200K (!) of space on
x86-64 Linux.
(Assignee)

Comment 1

9 months ago
Created attachment 8893472 [details] [diff] [review]
out-of-line type-specific Pickle::Write* methods
Attachment #8893472 - Flags: review?(wmccloskey)
Attachment #8893472 - Flags: review?(wmccloskey) → review+

Comment 2

9 months ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c541ddcbcac5
out-of-line type-specific Pickle::Write* methods; r=billm
https://hg.mozilla.org/mozilla-central/rev/c541ddcbcac5
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.