Open Bug 1387139 Opened 9 years ago Updated 3 years ago

Blue line above rectangular tabs need to take Windows 10 accent into account

Categories

(Firefox :: Theme, defect, P4)

57 Branch
defect

Tracking

()

People

(Reporter: alexical, Unassigned)

Details

(Whiteboard: [reserve-photon-visual][p2])

Attachments

(3 files)

Attached image AccentRed.PNG
See the attachments. - When the accent color on Windows 10 is different from the default, the bar at the top of the tab should probably match. - When the window is not focused, it looks a little bit wrong because the grey line at the top of the unfocused way has the illusion of disappearing over the lighter blue bar, making it look like the window has a 1 pixel line taken out of it at the top. - When "Show accent color on the following surfaces" is checked in the Windows Colors settings, and the user is using the default accent which matches our blue bar, the black borders oddly eat into the blue space. Maybe a different accent should be chosen in this case?
Attached image AccentMuted.PNG
Attached image AccentTitlebar.PNG
Version: 56 Branch → 57 Branch
Whiteboard: [photon-visual][triage]
Whiteboard: [photon-visual][triage] → [reserve-photon-visual][p2]
Flags: qe-verify?
Priority: -- → P3
Stephen, do you have an idea on how we could transform the accent color so that it looks right in the tab indicator? :)
Flags: needinfo?(shorlander)
It was intentionally designed to be a static color. We could look into grabbing more of the system accent colors and using one of those: https://docs.microsoft.com/en-us/windows/uwp/style/color#color-palette-building-blocks We should keep this in reserve and re-evaluate for post-57 work.
Flags: needinfo?(shorlander)
Priority: P3 → P4
Flags: qe-verify? → qe-verify+
QA Contact: ovidiu.boca
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: