http://searchfox.org/mozilla-central/rev/f0e4ae5f8c40ba742214e89aba3f554da0b89a33/dom/bindings/Codegen.py#1766 : > # Additionally, we want to throw if a caller does a bareword invocation > # of a constructor without |new|. We don't enforce this for chrome in > # realease builds to avoid the addon compat fallout of making that > # change. See bug 916644. I think we started applying this restriction for chrome in release builds in bug 979591.
Hello Bz, could you help to review this patch for removing outdated comments from Codegen.py? Thanks.
Assignee: nobody → echuang
Status: NEW → ASSIGNED
Attachment #8895294 - Flags: review?(bzbarsky)
Comment on attachment 8895294 [details] [diff] [review] Bug 1387149 - Remove outdated comment from Codegen.py. r?bz Please leave the part about how we throw for bareword invocations; that's important. r=me with that.
Attachment #8895294 - Flags: review?(bzbarsky) → review+
Update patch according to comment 2. Keep the comment # Additionally, we want to throw if a caller does a bareword invocation # of a constructor without |new|.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/227388c78b76 Remove outdated comment from Codegen.py. r=bz
You need to log in before you can comment on or make changes to this bug.