Closed
Bug 1387149
Opened 7 years ago
Closed 7 years ago
Remove outdated comment from Codegen.py: "We don't enforce this for chrome [...] to avoid addon compat fallout"
Categories
(Core :: DOM: Core & HTML, enhancement, P3)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: mstange, Assigned: edenchuang)
References
Details
Attachments
(1 file, 1 obsolete file)
1.56 KB,
patch
|
edenchuang
:
review+
|
Details | Diff | Splinter Review |
http://searchfox.org/mozilla-central/rev/f0e4ae5f8c40ba742214e89aba3f554da0b89a33/dom/bindings/Codegen.py#1766 : > # Additionally, we want to throw if a caller does a bareword invocation > # of a constructor without |new|. We don't enforce this for chrome in > # realease builds to avoid the addon compat fallout of making that > # change. See bug 916644. I think we started applying this restriction for chrome in release builds in bug 979591.
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•7 years ago
|
||
Hello Bz, could you help to review this patch for removing outdated comments from Codegen.py? Thanks.
Comment 2•7 years ago
|
||
Comment on attachment 8895294 [details] [diff] [review] Bug 1387149 - Remove outdated comment from Codegen.py. r?bz Please leave the part about how we throw for bareword invocations; that's important. r=me with that.
Attachment #8895294 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Update patch according to comment 2. Keep the comment # Additionally, we want to throw if a caller does a bareword invocation # of a constructor without |new|.
Attachment #8895294 -
Attachment is obsolete: true
Attachment #8906449 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/227388c78b76 Remove outdated comment from Codegen.py. r=bz
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/227388c78b76
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•