Remove outdated comment from Codegen.py: "We don't enforce this for chrome [...] to avoid addon compat fallout"

RESOLVED FIXED in Firefox 57

Status

()

Core
DOM
P3
normal
RESOLVED FIXED
10 months ago
8 months ago

People

(Reporter: mstange, Assigned: edenchuang)

Tracking

Trunk
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

10 months ago
http://searchfox.org/mozilla-central/rev/f0e4ae5f8c40ba742214e89aba3f554da0b89a33/dom/bindings/Codegen.py#1766 :

> # Additionally, we want to throw if a caller does a bareword invocation
> # of a constructor without |new|. We don't enforce this for chrome in
> # realease builds to avoid the addon compat fallout of making that
> # change. See bug 916644.

I think we started applying this restriction for chrome in release builds in bug 979591.

Updated

10 months ago
Priority: -- → P3
(Assignee)

Comment 1

10 months ago
Created attachment 8895294 [details] [diff] [review]
Bug 1387149 - Remove outdated comment from Codegen.py. r?bz

Hello Bz, could you help to review this patch for removing outdated comments from Codegen.py? Thanks.
Assignee: nobody → echuang
Status: NEW → ASSIGNED
Attachment #8895294 - Flags: review?(bzbarsky)
Comment on attachment 8895294 [details] [diff] [review]
Bug 1387149 - Remove outdated comment from Codegen.py. r?bz

Please leave the part about how we throw for bareword invocations; that's important.

r=me with that.
Attachment #8895294 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

8 months ago
Created attachment 8906449 [details] [diff] [review]
Bug 1387419 - Remove outdated comment from Codegen.py. r=bz

Update patch according to comment 2. Keep the comment

# Additionally, we want to throw if a caller does a bareword invocation
# of a constructor without |new|.
Attachment #8895294 - Attachment is obsolete: true
Attachment #8906449 - Flags: review+
(Assignee)

Updated

8 months ago
Keywords: checkin-needed

Comment 4

8 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/227388c78b76
Remove outdated comment from Codegen.py. r=bz
Keywords: checkin-needed

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/227388c78b76
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox57: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.