Open Bug 1387165 Opened 2 years ago Updated 5 months ago

Tab separator is not shown on the right side of a tab when dragging it to the left

Categories

(Firefox :: Theme, defect, P4)

57 Branch
defect

Tracking

()

Tracking Status
firefox57 --- fix-optional

People

(Reporter: dthayer, Unassigned)

Details

(Keywords: polish, regression, Whiteboard: [reserve-photon-animation])

STR:
- Drag a tab less than half a step to the right or left
- Watch it animate back to its original position
- Watch the tab separator line disappear ~300ms after the tab has settled into place

Expected results: the tab separator next to the active tab is gone before the tab has settled

Actual results: the tab separator disappears after the tab has settled, making it appear slightly glitchy
Whiteboard: [photon-visual][triage]
A few further notes:

- When dragging a tab to the left, there is no separator on the right, but when dragging the tab to the right, there is a separator on the left. We should probably be consistent here.

- When you drag a tab halfway to the right, so that it settles back to the left, the width of the tab seems to shrink down by one pixel once it's done animating.
Blocks: 1355507
Keywords: regression
Whiteboard: [photon-visual][triage] → [photon-animation][triage]
Flags: qe-verify?
Priority: -- → P4
Whiteboard: [photon-animation][triage] → [reserve-photon-animation]
Flags: qe-verify? → qe-verify+
QA Contact: stefan.georgiev

(In reply to Doug Thayer [:dthayer] from comment #0)

STR:

  • Drag a tab less than half a step to the right or left
  • Watch it animate back to its original position
  • Watch the tab separator line disappear ~300ms after the tab has settled
    into place

Expected results: the tab separator next to the active tab is gone before
the tab has settled

Actual results: the tab separator disappears after the tab has settled,
making it appear slightly glitchy

This appears to have been fixed by bug 1396833. There is now no longer a noticeable delay for the separator to disappear.

(In reply to Doug Thayer [:dthayer] from comment #1)

A few further notes:

  • When dragging a tab to the left, there is no separator on the right, but
    when dragging the tab to the right, there is a separator on the left. We
    should probably be consistent here.

  • When you drag a tab halfway to the right, so that it settles back to the
    left, the width of the tab seems to shrink down by one pixel once it's done
    animating.

Since the first part is fixed, I'll morph this bug for the second part. This isn't a regression from bug 1355507, as it was introduced with Australis tabs. I browsed through Firefox::Theme and Firefox::Tabbed Browser and didn't see a duplicate for it.

No longer blocks: 1355507
Summary: Tab separator disappears too late after tab drag → Tab separator is not shown on the right side of a tab when dragging it to the left
You need to log in before you can comment on or make changes to this bug.