138728 - Problem with localization in file open/save dialogs

Status: VERIFIED FIXED

(Core :: Internationalization: Localization, defect)

Description

[Dmitriy Geels]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (OS/2; U; Warp 4.5; ru-RU; rv:0.9.9) Gecko/20020311
BuildID:    2002031114

In file open/save dialogs, there are some strings (file type, may be something
else), Mozilla get from locale .jar, thoose strings are in unicode, and OS/2
doesn't work with unicode directly, so unicode text must be translated to
current system codepage.

Reproducible: Always
Steps to Reproduce:
1. Install any non-latin localization package (I use russian).
2. Select that language.
3. Open any file dialog.

Actual Results:  Then in file open/save dialogs you can see unicode strings with
lost second byte (file type field).

Expected Results:  Translate file type strings from unicode, to current system
codepage.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Michael, who should get this?  This sounds like a problem in nsFilePicker.cpp...

Comment 2

[Mike Kaply [:mkaply]]

I'll take it for now.

I'm not convinced, though - we have shipped many translated browsers 
(Including Japanese) without this problem.

Comment 3

[Mike Kaply [:mkaply]]

I humbly eat my words. I don't know how we missed this in translation.

Comment 4

[Yuying Long]

It sounds like a dup of bug 135854 which is i18n problem.

Reporter: can you try a file name with a space, e.g. "A B" see if you have same
problem? and could you provide a screen shot?  thanks!

Comment 5

[Mike Kaply [:mkaply]]

I think the issue here is Os/2 specific - that we are not converting the file 
type strings to a native charset before using them. I am investigating.

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Fix for problem

We need to call WideCharToMultibyte to convert the passed in Unicode strings
before using them.

Comment 7

[jhp (no longer active)]

Comment on attachment 80455 [details] [diff] [review]
Fix for problem

r=pedemont

Comment 8

[Mike Kaply [:mkaply]]

Comment on attachment 80455 [details] [diff] [review]
Fix for problem

sr=blizzard (platform specific code)

Comment 9

[Mike Kaply [:mkaply]]

Checked into trunk. Still need to go on branch.

Comment 10

[Yuying Long]

Reporter: could you please verify it on latest trunk build with OS/2? thanks!

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 80455 [details] [diff] [review]
Fix for problem

a=roc+moz for branch

Comment 12

[Mike Kaply [:mkaply]]

Fix checked into brancj

Comment 13

[Yuying Long]

Reporter: could you please verify it using latest build on OS/2? thanks!

Comment 14

[Asa Dotzler [:asa]]

adding fixed1.0.0 keyword (branch resolution). This bug has comments saying it
was fixed on the 1.0 branch and a bonsai checkin comment that agrees. To verify
the bug has been fixed on the 1.0 branch please replace the fixed1.0.0 keyword
with verified1.0.0.

Comment 15

[Yuying Long]

I don't see the problem here, mark as verified.

Please reopen if still see the problem.