1387352 - Youtube video is not rendered in layers-free mode

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

When I enabled layers-free mode, youtube video was not rendered.

Comment 1

[Sotaro Ikeda [:sotaro]]

WebRenderLayerManager::CreateImageKey() returns Nothing() if ImageContainer is async, since it does not use ImageKey instead it uses Pipeline. But it makes WebRenderLayerManager::PushImage() return false and then resulted to item->CreateWebRenderCommands() returned false. WebRenderLayerManager::CreateWebRenderCommandsFromDisplayList() recognized that item failed to generate WebRender command and then tried to fall backed with WebRenderLayerManager::PushItemAsImage().

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix async ImageContainer handling in layers-free mode

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8893709 [details] [diff] [review]
patch - Fix async ImageContainer handling in layers-free mode

Review of attachment 8893709 [details] [diff] [review]:
-----------------------------------------------------------------

Please update commit message to be more specific, maybe mention that this avoids falling into the fallback codepath for async ImageContainers.

Comment 4

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d43089ffd587634cb0695d7b21d32747beef92c

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7cfcee941c0
Avoids falling into the fallback codepath for async ImageContainers in layers-free mode r=kats

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d7cfcee941c0