Closed Bug 1387354 Opened 7 years ago Closed 7 years ago

Window controls are rendered twice with the accent color in title bar activated on Windows 10

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Platform:
Unspecified
Windows 10
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 58
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 --- verified
firefox58 --- verified

People

(Reporter: pascalc, Assigned: dao)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [reserve-photon-visual] fixed by bug 1366405)

Attachments

(1 file)

Screencast with the steps to reproduce the bug
1.84 MB, video/mp4
Details 
Tested with Windows 10 + Nightly 20170803

Sorry for the vague terminology I am using, I am an occasionnal Windows user only and I don't use it in English but French.

I am attaching a screencast that shows how to reproduce the bug, I found this bug on a pretty vanilla windows installation.

If you use activate toolbar colors in Windows, our window controls (resize, close) are drawn twice giving a king of blurry effect. The problem doesn't exist if you don't activate toolbar colors in windows.
Component: Shell Integration → Widget: Win32
Product: Firefox → Core
Blocks: photon-visual
Component: Widget: Win32 → Theme
Product: Core → Firefox
Whiteboard: [photon-visual][triage]
Flags: qe-verify+
Priority: -- → P3
QA Contact: ovidiu.boca
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Keywords: regressionwindow-wanted
The pushlog result from mozregression:

21:46.29 INFO: Last good revision: 4a39adfb94aef8c4ea30ba7ff1ec5673251e4796
21:46.29 INFO: First bad revision: df0fff1d1e83f2ff395cc3c5150e7f4e9365e3eb
21:46.29 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4a39adfb94aef8c4ea30ba7ff1ec5673251e4796&tochange=df0fff1d1e83f2ff395cc3c5150e7f4e9365e3eb
status-firefox56: --- → affected
Depends on: 1196266
Keywords: regressionwindow-wanted → regression
Blocks: 1196266
No longer blocks: photon-visual
No longer depends on: 1196266
Summary: Window controls on Windows 10 with toolbar colors activated are messed up in 57 → Window controls are rendered twice with the accent color in title bar activated on Windows 10
See Also: → 1401924
Depends on: 1366405
Should be fixed by bug 1366405. Pascal, could you please check in the next nightly build?
Flags: needinfo?(pascalc)
(In reply to Dão Gottwald [::dao] from comment #5)
> Should be fixed by bug 1366405. Pascal, could you please check in the next
> nightly build?

Yes, this is working now with Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0 ID:20170929100122
Flags: needinfo?(pascalc)
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57: fix-optional → fixed
Resolution: --- → FIXED
Whiteboard: [reserve-photon-visual] → [reserve-photon-visual] fixed by bug 1366405
Target Milestone: --- → Firefox 58
Assignee: nobody → dao+bmo
status-firefox56: --- → unaffected
status-firefox-esr52: --- → unaffected
Priority: P3 → P1
Based on comment 6, marking this bug verified on Firefox 58
status-firefox58: fixed → verified
Verified issue as fixed with Windows 10x32 and Windows 10x64 using 57.0b9 20171016185129.
Status: RESOLVED → VERIFIED
No longer blocks: 1196266
Regressed by: 1196266
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: