1387380 - Remove capabilities negotiation from Marionette

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P2)

Description

[Andreas Tolfsen ❲:ato❳]

Marionette reads the "capabilities" key, containing the old-style
Selenium New Session body with "desiredCapabilities" and
"requiredCapabilities" fields:

    https://searchfox.org/mozilla-central/rev/30a47c4339bd397b937abdb2305f99d3bb537ba6/testing/marionette/driver.js#670-677

In an effort to get rid of desired/required capabilities negotiation
in Marionette, now that geckodriver does the negotiation for us,
we should look at the outermost cmd.parameters JSON Object so that
geckodrive can remove the inner "capabilities" field down the line.

Furthermore, this implies we can get rid of the ‘merging’ of
capabilities objects.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1387380 - Stop capabilities negotiation in Marionette.

The geckodriver HTTPD proxy implements WebDriver conforming capabilities
negotation and it is unnecessary to do this in the Marionette WebDriver
service.  The capabilities matching that Marionette implements is also
not as good as the implementation found in geckodriver.

The WebDriver:NewSession command will still accept a JSON Object of
"configuration" capabilities that carry the pre-matched capabilities from
geckodriver.  These will be used as configuration options for the session.
Type- and bounds checks will still be performed on this input.

Review commit: https://reviewboard.mozilla.org/r/164998/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164998/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8893936 [details]
Bug 1387380 - Stop capabilities negotiation in Marionette.

https://reviewboard.mozilla.org/r/164998/#review170726

Looks fine to me generally. There is one thing I would like to get reverted through to be closer to the spec naming convention.

::: testing/marionette/session.js:275
(Diff revision 1)
>        ["moz:headless", Cc["@mozilla.org/gfx/info;1"].getService(Ci.nsIGfxInfo).isHeadless],
>      ]);
>    }
>  
>    /**
> -   * @param {string} key
> +   * @param {string} name

In the spec we list the name as 'key' and so I think we should keep it here.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8893936 [details]
Bug 1387380 - Stop capabilities negotiation in Marionette.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164998/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34af7208f1c0
Stop capabilities negotiation in Marionette. r=whimboo

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/34af7208f1c0