1387381 - Remove nsXPIDLString local variables

Status: RESOLVED FIXED

(Core :: General, enhancement)

Description

[Nicholas Nethercote [inactive]]

This will remove a big chunk of the remaining nsXPIDLString occurrences.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove nsXPIDLString local variables

nsXPIDLStrings are marked as VOIDED upon initialization. Most of these local
nsXPIDLString variables are immediately set via getter_Copies(), which will
either assign a string value (using Adopt()) or do SetIsVoid(). These can be
trivially converted to nsString, which will get the same treatment.

The patch suitably converts the remaining nsXPIDLString local variable as well.

Comment 2

[Eric Rahm [:erahm]]

Comment on attachment 8893741 [details] [diff] [review]
Remove nsXPIDLString local variables

Review of attachment 8893741 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, just one small followup.

::: extensions/spellcheck/src/mozSpellChecker.cpp
@@ +419,3 @@
>        nsCOMPtr<mozISpellI18NManager> serv(do_GetService("@mozilla.org/spellchecker/i18nmanager;1", &rv));
>        NS_ENSURE_SUCCESS(rv, rv);
> +      return serv->GetUtil(nullptr, getter_AddRefs(mConverter));

This is kind of sketchy, I can look at the code and confirm the param isn't used but we don't know that will always be the case. Can you just convert the idl to take an AString instead of wstring?

Or maybe all this is deprecated so it's not worth dealing with.

Comment 3

[Nicholas Nethercote [inactive]]

> This is kind of sketchy, I can look at the code and confirm the param isn't
> used but we don't know that will always be the case. Can you just convert
> the idl to take an AString instead of wstring?
> 
> Or maybe all this is deprecated so it's not worth dealing with.

C++ methods like this generally check their arguments are null and fail if so. (NS_ENSURE_ARG() is the standard way.) So I believe the responsibility lies with the callee, not the caller. So I'll leave it as is.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3984a9f49bcf7b7cb073988f1570e975601ef4ea
Bug 1387381 - Remove nsXPIDLString local variables. r=erahm.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3984a9f49bcf
Remove nsXPIDLString local variables. r=erahm.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3984a9f49bcf